PWA Support #68
PWA Support #68
Conversation
This reverts commit ad923a4.
deployed preview: https://68.connect-d5y.pages.devWelcome to new-connect! Make sure to:
Mobile
Desktop
|
| @@ -0,0 +1,5 @@ | |||
| { | |||
|
|
||
| manifest: { | ||
| name: 'connect', | ||
| short_name: 'conect', |
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
Will remove - was just for my testing on vercel
| "@vite-pwa/assets-generator": "^0.2.4", | ||
| "vite-plugin-pwa": "^0.20.0", | ||
| "sharp": "0.32.6", | ||
| "sharp-ico": "0.1.5", | ||
| "workbox-window": "^7.1.0", |
There was a problem hiding this comment.
what do these 5 new dependencies do?
There was a problem hiding this comment.
These are required for the minimal config vite-pwa plugin.
They are used generate the assets like splash screens, icons, etc. at build time and are not included in the applications bundle.
There's an alternative way to use "resolutions" in package.json for the sharp and sharp-ico libs but I couldn't get them to work in this repo.
There was a problem hiding this comment.
It's a declarative plugin instead of an imperative config.
|
This PR is +100 lines net, including a bunch of new dependencies and configs. I suspect doing all the PWA stuff ourselves would be less than or equal to this. |
Adding the splash screen meta tags is 60 lines alone in the html Maintaining a list of sizes of assets for new devices, configuring service workers, etc. is a lot of grunt work that is not something I think any team should really be focused on maintaining or generating. Much more than 100 lines unfortunately |
https://new-connect-beta.vercel.app/
Add to home screen
turn on airplane mode to see offline fallback - not sure what you exactly want with this?
Assets are all generated from the two logo svgs - run build to see them in the dist folder