Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma 3 boots into Dashcam Mode #1093

Open
Verylukyguy opened this issue Nov 7, 2023 · 9 comments
Open

Comma 3 boots into Dashcam Mode #1093

Verylukyguy opened this issue Nov 7, 2023 · 9 comments

Comments

@Verylukyguy
Copy link

Describe the bug

The Comma 3 boots up intermittently in Dashcam Mode, seemingly after restarting the vehicle and resolves if the vehicle is restarted again.
It is fingerprinting properly using FPv1; there are no missing Platforms on my Useradmin page.

Provide a route where the issue occurs

df51b2195de66a9b|2023-11-03--18-17-10--0

openpilot version

Comma Nightly @ 105ffa0

Additional info

No response

@Verylukyguy Verylukyguy added the bug label Nov 7, 2023
@sshane
Copy link
Contributor

sshane commented Nov 8, 2023

When you added your fingerprint in commaai/openpilot#21545, it used a script which did not check the origin bus, as usually 0/2 is the same bus (PT and camera), but on ASCM GM, 2 is the chassis. There happens to be the same addresses with different lengths on 0 and 2 (like ECMEngineStatus), so some addresses in your fingerprint have an incorrect length on bus 0.

@Verylukyguy
Copy link
Author

Verylukyguy commented Nov 8, 2023

There were also earlier attempts to add my vehicle's fingerprint: commaai/openpilot#2440 and commaai/openpilot#21030
Maybe these are more complete/accurate.

The Acadia port originated here: commaai/openpilot#338 and commaai/openpilot#453

@Verylukyguy
Copy link
Author

Verylukyguy commented Apr 8, 2024

It does not appear to be a Fingerprinting issue because the Platform is correct on my Useradmin page when this happens.
This issue developed only after a change in OpenPilot when a commit was merged, it had been working fine for three years.

@sshane
Copy link
Contributor

sshane commented Apr 8, 2024

Likely caused by commaai/openpilot#27245. Can you share a recent bad route with uploaded rlogs?

@Verylukyguy
Copy link
Author

Verylukyguy commented Apr 8, 2024

This one is from yesterday: df51b2195de66a9b/0000005a--78b136e680/0

@sshane
Copy link
Contributor

sshane commented Apr 8, 2024

I should have a fix next week for you to test.

@Verylukyguy
Copy link
Author

I am ready when you are @sshane.

@Verylukyguy
Copy link
Author

Here is another route: df51b2195de66a9b/00000001--bc22ed8054/0

@Verylukyguy
Copy link
Author

Here is another route: df51b2195de66a9b/00000007--12eddfcd96/0

@sshane sshane transferred this issue from commaai/openpilot Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants