Increase days of no Internet connectivity to 30 #1096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quickly realized how silly it would be to get a nag so early on, if increasing the MAX to 30.
|
Instead, we made it so you can reboot to reset this. Fair? Also, if this is broken at all, we def want to fix it. |
|
Rebooting is a fair compromise, and should encourage basic users to get their devices online regularly. Next time someone complains about the warning, I'll advise they reboot, and if that doesn't do the trick, we'll investigate accordingly. |
|
Sounds good |
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
May 22, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
May 23, 2020
This was referenced May 23, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Jun 2, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Jul 21, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Aug 21, 2020
sshane
added a commit
to sshane/openpilot
that referenced
this pull request
Sep 5, 2020
* SnG hack * Eased up Internet requirement See... commaai#1096 * VBATT CHARGING & Turn off charge after 3 hrs * Prii ZSS w/ Prime-centric tuning, etc. * Minimized custom fork warning * Update interface.py * Update thermald.py * Update interface.py * Update interface.py * Update lane_planner.py * ZSS Prius INDI Tune Co-authored-by: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com> Co-authored-by: ErichMoraga <mailto:ejmoraga@gmail.com|ejmoraga@gmail.com> Co-authored-by: d412k5t412 <36134180+d412k5t412@users.noreply.github.com>
sshane
added a commit
to sshane/openpilot
that referenced
this pull request
Sep 6, 2020
* merge ZSS to SA (#197) * SnG hack * Eased up Internet requirement See... commaai#1096 * VBATT CHARGING & Turn off charge after 3 hrs * Prii ZSS w/ Prime-centric tuning, etc. * Minimized custom fork warning * Update interface.py * Update thermald.py * Update interface.py * Update interface.py * Update lane_planner.py * ZSS Prius INDI Tune Co-authored-by: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com> Co-authored-by: ErichMoraga <mailto:ejmoraga@gmail.com|ejmoraga@gmail.com> Co-authored-by: d412k5t412 <36134180+d412k5t412@users.noreply.github.com> * revert chmod * revert chmod * revert comment for standstill_req * revert interface changes * revert all carstate changes * add code to detect ZSS * fix * add ZSS code * use needs_angle_offset * switch around for diff readability * diff readability * diff readability * test * this should work * move code * ugh, fix * this should work * use hex like the other fp checks * ZSS tuning * revert to test * better implementation of getting ZSS * better implementation of getting ZSS * revert * follow naming conventions * simplify hasZss tuning * one line * debug * rename * gather more data * remove debugging * just for safety * this is probably better * nah this is fine Co-authored-by: ErichMoraga <33645296+ErichMoraga@users.noreply.github.com> Co-authored-by: ErichMoraga <mailto:ejmoraga@gmail.com|ejmoraga@gmail.com> Co-authored-by: d412k5t412 <36134180+d412k5t412@users.noreply.github.com>
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Oct 6, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Oct 24, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Nov 27, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Dec 18, 2020
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Feb 27, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Mar 30, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
May 20, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
May 26, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Jun 11, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Jul 23, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Aug 7, 2021
sobomax
pushed a commit
to sobomax/openpilot
that referenced
this pull request
Aug 10, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Aug 27, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Sep 11, 2021
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Oct 28, 2021
I like 1 month, since it's the avg. interval b/w releases. See... commaai#1096 commaai#22607
ErichMoraga
added a commit
to ErichMoraga/openpilot
that referenced
this pull request
Nov 29, 2021
I like 1 month, since it's the avg. interval b/w releases. See... commaai#1096 commaai#22607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making good on @geohot's promise...
https://discordapp.com/channels/469524606043160576/524328425415245827/664532003382755349