Honda Pilot 2017 Port (#161) #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * Update fingerprints.py * Update carstate.py * Update hondacan.py * Update interface.py * Update interface.py * Update interface.py * Update README.md * Update README.md * Update README.md * Update fingerprints.py * Update carstate.py * Update hondacan.py * Update interface.py * Update carstate.py * Update hondacan.py * Update README.md * Update fingerprints.py * Update carstate.py * Update carstate.py * Update carstate.py * Update hondacan.py * Update interface.py * Update carstate.py * Update carstate.py * Update Pilot Fingerprint * Update fingerprints.py * Give pilot its own definition and not use ILX * add pilot argument * Add Pilot interface * Add pilot argument * Update interface.py * Parse Different gear on pilot * Add steer max * Fixed duplication of steer max value * Adjust PID's for steering * Update carcontroller.py * Change Steer Ratio and wheelbase * Update Steer fault values Steer fault value of 3, does not seem to effect anything * Update Kp,Ki Ratio * Update interface.py * Update readme for Pilot * add pilot * Update fingerprints.py * Update carstate.py * add signals * add signal
mcampa
reviewed
Feb 11, 2018
| elif can_gear_shifter == 0x20: | ||
| return "drive" | ||
| elif can_gear_shifter == 0x2: | ||
| return "sport" |
There was a problem hiding this comment.
Here is a bug. This function will never return "sport" because at line 14 you are assuming that for all Hondas 0x02 is "reverse"
There was a problem hiding this comment.
Good catch. Will fix this in internal repo and it will be in next release. Currently, this bug doesn't result in unexpected behaviors as both S and R don't allow OP engagement.
There was a problem hiding this comment.
Can you guys add support to "sport" mode 🙏? Stock ACC work on sport mode.
I have this line patched to return "drive" so OP can drive in sport mode.
Or maybe just do what I'm doing and return "drive" instead of "sport" for all other cars. If you'd like I can open a PR for this.
There was a problem hiding this comment.
@mcampa , the rational behind not allowing OP in Sport mode is that it might require a re-tuning, since the car controls might respond differently. Not sure if that's even true actually...
To match Panda repo.
Dibs on SAFETY_GM numerical value
Safety Reference for Honda Bosch
Consolidated my fingerprint and removed duplicates and ordered the fingerprint for the RAV4H. Double Checked.
* Interpolate ki/kp for steering PID loop Very much needed for the Volt port: car ping-pongs with low kp on high speeeds, and the loop is unstable with high kp on low speeds. Also, removes "number or array?" logic from PIController, now that all the callers use interpolation ofr ki/kp. * Pass speed to steering PID loop for ki/kp interpolation * Remove unused numbers import
|
Will be merged in next release |
edukinara
pushed a commit
to edukinara/openpilot
that referenced
this pull request
Jul 18, 2019
* Add highway speed braking profiles * Fix CS.vEgo to v_ego * Add highway speed braking profiles
pd0wm
pushed a commit
that referenced
this pull request
Nov 5, 2019
c0eba096b remove obsolete Subaru dbc file f7bce9ee0 Fixes to vw dbc adb672657 Added VW comment about ignition bit c51631617 Fixes and new message for VW MQB, fix for Accord Touring (#193) a09bf725e fixed to luxgen dbc file f00f6289a Create luxgen_s5_2014.dbc (#101) 024612b20 Fix steer angle factor for toyota 7311ee70e Lexus is adjustment (#192) f04ce577e Updates for Volkswagen support (#191) git-subtree-dir: opendbc git-subtree-split: c0eba096bc74033ea54abfd56406b5af3108727c
DrFritzi
pushed a commit
to DrFritzi/openpilotOld
that referenced
this pull request
Jan 30, 2021
fix and update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md
Update fingerprints.py
Update carstate.py
Update hondacan.py
Update interface.py
Update interface.py
Update interface.py
Update README.md
Update README.md
Update README.md
Update fingerprints.py
Update carstate.py
Update hondacan.py
Update interface.py
Update carstate.py
Update hondacan.py
Update README.md
Update fingerprints.py
Update carstate.py
Update carstate.py
Update carstate.py
Update hondacan.py
Update interface.py
Update carstate.py
Update carstate.py
Update Pilot Fingerprint
Update fingerprints.py
Give pilot its own definition and not use ILX
add pilot argument
Add Pilot interface
Add pilot argument
Update interface.py
Parse Different gear on pilot
Add steer max
Fixed duplication of steer max value
Adjust PID's for steering
Update carcontroller.py
Change Steer Ratio and wheelbase
Update Steer fault values
Steer fault value of 3, does not seem to effect anything
Update Kp,Ki Ratio
Update interface.py
Update readme for Pilot
add pilot
Update fingerprints.py
Update carstate.py
add signals
add signal