-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKG fingerprinting: add matches from platform codes #26939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using fleet data:
|
start on making existing fingerprinting functions use the config, instead of entirely replacing them
Decided to revert the revert and just add matches with platform codes. Requiring two ECUs, matching independently with platform codes and exact versions, etc. is just masking the missing ECU problem which should be handled separately and explicitly -- this PR is already doing a lot. |
sshane
changed the title
HKG: reliable fuzzy fingerprinting
HKG fingerprinting: add matches from platform codes
Jun 10, 2023
5 tasks
replaced with #28531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a draft. There are some cars that use the same platform codes, but are fundamentally different as far as openpilot is concerned. One big example are the older Ioniqs; some have radars, some use FCA or SCC for AEB, some are legacy, some send the LFA message, some support different torques, etc.
For these cars, we just ignore the multiple matches. @adeebshihadeh I am thinking we can track the cars we won't support with this fuzzy fingerprinting and work to combine the platforms over time (with good detection for the different features)
All Hyundai:
You can see the two platform codes in the Palisade's versions since we include the Telluride too (
ON
).