Small cleanup #275
Merged
Small cleanup #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiasini
reviewed
Jun 28, 2018
selfdrive/car/honda/carcontroller.py
Outdated
| else: | ||
| hud_car = 1 | ||
| else: | ||
| if enabled and hud_show_car: |
There was a problem hiding this comment.
I prefer the old version: less var name repetitions.
There was a problem hiding this comment.
you're right. that does look sloppy
There was a problem hiding this comment.
if not enabled:
hud_car = 0
elif not hud_show_car:
hud_car = 1
else:
hud_car = 2
How do you feel about something like this?
There was a problem hiding this comment.
still prefer the original :)
klaus385
pushed a commit
to klaus385/openpilot
that referenced
this pull request
Dec 31, 2018
* mass unit conversions * flat/explicit conditions * fix typos * remove hardcode * Update README.md * Update carcontroller.py
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
* mass unit conversions * flat/explicit conditions * fix typos * remove hardcode * Update README.md * Update carcontroller.py
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
May 21, 2024
* mapd: Remove more legacy implementation * bump cereal
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-cleaner mass conversions and wheel speed estimation in gm and ford
-fixed some comment typos
-clearer IF conditions in honda/carcontroller