Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kia: add missing fwdCamera for Niro HEV 2023 #27557

Merged
merged 3 commits into from Mar 20, 2023
Merged

Kia: add missing fwdCamera for Niro HEV 2023 #27557

merged 3 commits into from Mar 20, 2023

Conversation

cpaioletti
Copy link
Contributor

Excerpt from the carParam:

{'carParams': {'alternativeExperience': 0,
'autoResumeSng': True,
'carFingerprint': 'mock',
'carFw': [{'address': 2004,
'brand': 'hyundai',
'bus': 1,
'ecu': 'eps',
'fwVersion': b'\xf1\x00SG2 MDPS C 1.00 1.06 56310AT050\x00 4SG2C106',
'logging': False,
'request': [b'"\xf1\x00'],
'responseAddress': 2012,
'subAddress': 0},
{'address': 2000,
'brand': 'hyundai',
'bus': 1,
'ecu': 'fwdRadar',
'fwVersion': b'\xf1\x00SG2_ RDR ----- 1.00 1.01 99110-AT000 ',
'logging': False,
'request': [b'"\xf1\x00'],
'responseAddress': 2008,
'subAddress': 0},
{'address': 2017,
'brand': 'hyundai',
'bus': 1,
'ecu': 'transmission',
'fwVersion': b'\xf1\x00PSBG2552 D121049\x00\x00\x00DSG2G16XXH049NS6MC\xe3x',
'logging': False,
'request': [b'"\xf1\x00'],
'responseAddress': 2025,
'subAddress': 0},
{'address': 1988,
'brand': 'hyundai',
'bus': 1,
'ecu': 'fwdCamera',
'fwVersion': b'\xf1\x00SG2HMFC AT USA LHD 1.01 1.09 99211-AT000 220801',
'logging': False,
'request': [b'"\xf1\x00'],
'responseAddress': 1996,
'subAddress': 0},
{'address': 2016,
'brand': 'hyundai',
'bus': 1,
'ecu': 'engine',
'fwVersion': b'\xf1\x87391S3-08AF0\xf1\x81HM6M7_0a0_D00',
'logging': False,
'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
'responseAddress': 2024,
'subAddress': 0},
{'address': 2000,
'brand': 'hyundai',
'bus': 1,
'ecu': 'fwdRadar',
'fwVersion': b'\xf1\x8799110AT000\xf1\x00SG2_ RDR ----- 1.00 1.01 99110-AT000 ',
'logging': False,
'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
'responseAddress': 2008,
'subAddress': 0},
{'address': 2004,
'brand': 'hyundai',
'bus': 1,
'ecu': 'eps',
'fwVersion': b'\xf1\x8756310AT050\x00\xf1\x00SG2 MDPS C 1.00 1.06 56310AT050\x00 4SG2C106',
'logging': False,
'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
'responseAddress': 2012,
'subAddress': 0},
{'address': 2017,
'brand': 'hyundai',
'bus': 1,
'ecu': 'transmission',
'fwVersion': b'\xf1\x8795441-2BGJ0\x00\xf1\x81D121049\x00\x00\x00\xf1\x00PSBG2552 D121049\x00\x00\x00DSG2G16XXH049NS6'
b'MC\xe3x',
'logging': False,
'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
'responseAddress': 2025,
'subAddress': 0},
{'address': 2000,
'brand': 'hyundai',
'bus': 4,
'ecu': 'fwdRadar',
'fwVersion': b'\xf1\x00SG2_ RDR ----- 1.00 1.01 99110-AT000 ',
'logging': False,
'request': [b'"\xf1\x00'],
'responseAddress': 2008,
'subAddress': 0},
{'address': 1975,
'brand': 'hyundai',
'bus': 4,
'ecu': 'cornerRadar',
'fwVersion': b'\xf1\x00SG2 BCW RR 1.01 , 1.04 (wQ\x83"\x02\x01\x03@',
'logging': True,
'request': [b'"\xf1\x00'],
'responseAddress': 1983,
'subAddress': 0},
{'address': 1988,
'brand': 'hyundai',
'bus': 4,
'ecu': 'fwdCamera',
'fwVersion': b'\xf1\x00SG2HMFC AT USA LHD 1.01 1.09 99211-AT000 220801',
'logging': False,
'request': [b'"\xf1\x00'],
'responseAddress': 1996,
'subAddress': 0},
{'address': 2017,
'brand': 'mazda',
'bus': 1,
'ecu': 'transmission',
'fwVersion': b'D121049\x00\x00\x00',
'logging': False,
'request': [b'"\xf1\x88'],
'responseAddress': 2025,
'subAddress': 0},
{'address': 2016,
'brand': 'subaru',
'bus': 1,
'ecu': 'engine',
'fwVersion': b'0TD23N6HGXD00\x00',
'logging': False,
'request': [b'>\x00', b'"\xf1\x82'],
'responseAddress': 2024,
'subAddress': 0},
{'address': 2017,
'brand': 'subaru',
'bus': 1,
'ecu': 'transmission',
'fwVersion': b'DSG2G16XXH049NS6',
'logging': False,
'request': [b'>\x00', b'"\xf1\x82'],
'responseAddress': 2025,
'subAddress': 0},
{'address': 2016,
'brand': 'volkswagen',
'bus': 1,
'ecu': 'engine',
'fwVersion': b'\xf1\x87391S3-08AF0\xf1\x820TD23N6HGXD00\x00',
'logging': False,
'request': [b'"\xf1\x87\xf1\x89\xf1\x82'],
'responseAddress': 2024,
'subAddress': 0},
{'address': 2017,
'brand': 'volkswagen',
'bus': 1,
'ecu': 'transmission',
'fwVersion': b'\xf1\x8795441-2BGJ0\x00\xf1\x89D121049\x00\x00\x00\xf1\x82DSG2G16XXH049NS6',
'logging': False,
'request': [b'"\xf1\x87\xf1\x89\xf1\x82'],
'responseAddress': 2025,
'subAddress': 0}],

{'carParams': {'alternativeExperience': 0,
               'autoResumeSng': True,
               'carFingerprint': 'mock',
               'carFw': [{'address': 2004,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'eps',
                          'fwVersion': b'\xf1\x00SG2 MDPS C 1.00 1.06 56310AT050\x00 4SG2C106',
                          'logging': False,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 2012,
                          'subAddress': 0},
                         {'address': 2000,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'fwdRadar',
                          'fwVersion': b'\xf1\x00SG2_ RDR -----      1.00 1.01 99110-AT000         ',
                          'logging': False,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 2008,
                          'subAddress': 0},
                         {'address': 2017,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'transmission',
                          'fwVersion': b'\xf1\x00PSBG2552  D121049\x00\x00\x00DSG2G16XXH049NS6MC\xe3x',
                          'logging': False,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 2025,
                          'subAddress': 0},
                         {'address': 1988,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'fwdCamera',
                          'fwVersion': b'\xf1\x00SG2HMFC  AT USA LHD 1.01 1.09 99211-AT000 220801',
                          'logging': False,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 1996,
                          'subAddress': 0},
                         {'address': 2016,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'engine',
                          'fwVersion': b'\xf1\x87391S3-08AF0\xf1\x81HM6M7_0a0_D00',
                          'logging': False,
                          'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
                          'responseAddress': 2024,
                          'subAddress': 0},
                         {'address': 2000,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'fwdRadar',
                          'fwVersion': b'\xf1\x8799110AT000\xf1\x00SG2_ RDR -----      1.00 1.01 99110-AT000         ',
                          'logging': False,
                          'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
                          'responseAddress': 2008,
                          'subAddress': 0},
                         {'address': 2004,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'eps',
                          'fwVersion': b'\xf1\x8756310AT050\x00\xf1\x00SG2 MDPS C 1.00 1.06 56310AT050\x00 4SG2C106',
                          'logging': False,
                          'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
                          'responseAddress': 2012,
                          'subAddress': 0},
                         {'address': 2017,
                          'brand': 'hyundai',
                          'bus': 1,
                          'ecu': 'transmission',
                          'fwVersion': b'\xf1\x8795441-2BGJ0\x00\xf1\x81D121049\x00\x00\x00\xf1\x00PSBG2552  D121049\x00\x00\x00DSG2G16XXH049NS6'
                                       b'MC\xe3x',
                          'logging': False,
                          'request': [b'"\xf1\x87\xf1\x81\xf1\x00'],
                          'responseAddress': 2025,
                          'subAddress': 0},
                         {'address': 2000,
                          'brand': 'hyundai',
                          'bus': 4,
                          'ecu': 'fwdRadar',
                          'fwVersion': b'\xf1\x00SG2_ RDR -----      1.00 1.01 99110-AT000         ',
                          'logging': False,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 2008,
                          'subAddress': 0},
                         {'address': 1975,
                          'brand': 'hyundai',
                          'bus': 4,
                          'ecu': 'cornerRadar',
                          'fwVersion': b'\xf1\x00SG2 BCW RR 1.01 , 1.04 (wQ\x83"\x02\x01\x03@',
                          'logging': True,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 1983,
                          'subAddress': 0},
                         {'address': 1988,
                          'brand': 'hyundai',
                          'bus': 4,
                          'ecu': 'fwdCamera',
                          'fwVersion': b'\xf1\x00SG2HMFC  AT USA LHD 1.01 1.09 99211-AT000 220801',
                          'logging': False,
                          'request': [b'"\xf1\x00'],
                          'responseAddress': 1996,
                          'subAddress': 0},
                         {'address': 2017,
                          'brand': 'mazda',
                          'bus': 1,
                          'ecu': 'transmission',
                          'fwVersion': b'D121049\x00\x00\x00',
                          'logging': False,
                          'request': [b'"\xf1\x88'],
                          'responseAddress': 2025,
                          'subAddress': 0},
                         {'address': 2016,
                          'brand': 'subaru',
                          'bus': 1,
                          'ecu': 'engine',
                          'fwVersion': b'0TD23N6HGXD00\x00',
                          'logging': False,
                          'request': [b'>\x00', b'"\xf1\x82'],
                          'responseAddress': 2024,
                          'subAddress': 0},
                         {'address': 2017,
                          'brand': 'subaru',
                          'bus': 1,
                          'ecu': 'transmission',
                          'fwVersion': b'DSG2G16XXH049NS6',
                          'logging': False,
                          'request': [b'>\x00', b'"\xf1\x82'],
                          'responseAddress': 2025,
                          'subAddress': 0},
                         {'address': 2016,
                          'brand': 'volkswagen',
                          'bus': 1,
                          'ecu': 'engine',
                          'fwVersion': b'\xf1\x87391S3-08AF0\xf1\x820TD23N6HGXD00\x00',
                          'logging': False,
                          'request': [b'"\xf1\x87\xf1\x89\xf1\x82'],
                          'responseAddress': 2024,
                          'subAddress': 0},
                         {'address': 2017,
                          'brand': 'volkswagen',
                          'bus': 1,
                          'ecu': 'transmission',
                          'fwVersion': b'\xf1\x8795441-2BGJ0\x00\xf1\x89D121049\x00\x00\x00\xf1\x82DSG2G16XXH049NS6',
                          'logging': False,
                          'request': [b'"\xf1\x87\xf1\x89\xf1\x82'],
                          'responseAddress': 2025,
                          'subAddress': 0}],
Added missing comma to Line 1659 to fix previous new firmware additions for 2023 Kia Niro Hybrid
@sshane sshane added fingerprint car vehicle-specific hyundai labels Mar 10, 2023
@sshane
Copy link
Contributor

sshane commented Mar 16, 2023

Can you post the dongle id for this device? It's in settings on your comma three

@cpaioletti
Copy link
Contributor Author

Can you post the dongle id for this device? It's in settings on your comma three

7387ab2a564c6d9f

@sshane sshane changed the title Update values.py for 2023 Kia Niro HEV Kia: add missing fwdCamera for 2023 Kia Niro HEV Mar 20, 2023
@sshane sshane changed the title Kia: add missing fwdCamera for 2023 Kia Niro HEV Kia: add missing fwdCamera for Niro HEV 2023 Mar 20, 2023
@sshane sshane merged commit 285204c into commaai:master Mar 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants