Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

car docs: list all needed hardware #28212

Merged
merged 20 commits into from May 22, 2023
Merged

car docs: list all needed hardware #28212

merged 20 commits into from May 22, 2023

Conversation

maxime-desroches
Copy link
Contributor

No description provided.

selfdrive/car/docs_definitions.py Show resolved Hide resolved
selfdrive/car/docs_definitions.py Outdated Show resolved Hide resolved
selfdrive/car/docs_definitions.py Outdated Show resolved Hide resolved
selfdrive/car/docs_definitions.py Outdated Show resolved Hide resolved
selfdrive/car/docs_definitions.py Outdated Show resolved Hide resolved
selfdrive/car/ford/values.py Outdated Show resolved Hide resolved
@maxime-desroches maxime-desroches marked this pull request as draft May 17, 2023 04:28
@maxime-desroches maxime-desroches marked this pull request as ready for review May 17, 2023 18:12
selfdrive/car/ford/values.py Outdated Show resolved Hide resolved
selfdrive/car/docs_definitions.py Outdated Show resolved Hide resolved
This reverts commit 139650a.
@sshane
Copy link
Contributor

sshane commented May 20, 2023

It would be nice if the car docs diff bot worked on these kinds of PRs! But I couldn't get it to save the structure in the pickle file like it says is possible. If you have extra time in the future, I think we want to get rid of all the custom pickle stuff and just parse the markdown file directly, which should be simpler. https://github.com/commaai/openpilot/blob/master/selfdrive/debug/dump_car_info.py https://github.com/commaai/openpilot/blob/master/selfdrive/debug/print_docs_diff.py

@maxime-desroches
Copy link
Contributor Author

It would be nice if the car docs diff bot worked on these kinds of PRs! But I couldn't get it to save the structure in the pickle file like it says is possible. If you have extra time in the future, I think we want to get rid of all the custom pickle stuff and just parse the markdown file directly, which should be simpler. https://github.com/commaai/openpilot/blob/master/selfdrive/debug/dump_car_info.py https://github.com/commaai/openpilot/blob/master/selfdrive/debug/print_docs_diff.py

I was wondering why the bot never showed up. I will take a look

selfdrive/car/docs_definitions.py Outdated Show resolved Hide resolved
selfdrive/car/docs_definitions.py Show resolved Hide resolved
selfdrive/car/ford/values.py Outdated Show resolved Hide resolved
selfdrive/car/gm/values.py Show resolved Hide resolved
selfdrive/car/nissan/values.py Show resolved Hide resolved
selfdrive/car/tests/test_docs.py Show resolved Hide resolved
selfdrive/car/volkswagen/values.py Show resolved Hide resolved
@sshane sshane changed the title generic car parts car docs: list all needed hardware May 20, 2023
@maxime-desroches maxime-desroches marked this pull request as draft May 20, 2023 05:57
@maxime-desroches maxime-desroches marked this pull request as ready for review May 21, 2023 05:21
@maxime-desroches maxime-desroches merged commit 9f5f8b6 into master May 22, 2023
38 checks passed
@maxime-desroches maxime-desroches deleted the car_hardware branch May 22, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants