cars: log non-critical car faults #28338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
force-pushed
the
non-noentry-acc-fault
branch
from
b70ed6b
to
eb79529
Compare
sshane
changed the title
|
this would have exposed the possible cause behind #27961 earlier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds field to carstate and an event to log when some portion of the car's ADAS systems are faulted, but openpilot can still engage. for example, the camera on Nidec (and many others) wants to display a faulted signal but we block and send our own. this should only be used to log superficial faults, nothing that prevents any kind of control