ui: multilang offroad alerts #28512
Merged
ui: multilang offroad alerts #28512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
ui_multilang_offroad_alert
branch
from
60551a8
to
e599c98
Compare
deanlee
force-pushed
the
ui_multilang_offroad_alert
branch
3 times, most recently
from
c6aac45
to
f1e9fff
Compare
|
@sshane this is ready for review |
sshane
reviewed
Jun 12, 2023
sshane
requested changes
Jun 12, 2023
sshane
requested changes
Jun 13, 2023
|
LGTM besides those things! @adeebshihadeh what do you think? |
deanlee
force-pushed
the
ui_multilang_offroad_alert
branch
from
614f89c
to
c95c0b4
Compare
|
can you rebase one more time @deanlee? |
|
done |
sshane
reviewed
Jun 15, 2023
deanlee
force-pushed
the
ui_multilang_offroad_alert
branch
3 times, most recently
from
acdd144
to
14c5f66
Compare
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
deanlee
force-pushed
the
ui_multilang_offroad_alert
branch
from
14c5f66
to
b06b4bb
Compare
sshane
reviewed
Jun 22, 2023
sshane
reviewed
Jun 22, 2023
Co-authored-by: Shane Smiskol <shane@smiskol.com>
incognitojam
force-pushed
the
ui_multilang_offroad_alert
branch
from
93c40e4
to
b14e32e
Compare
|
Tested, seems to work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate a translations include file
selfdrive/ui/translations/generated_translations.hto multilingualize the offroad alerts