ui/networking: do not skip the connected network #29396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Aug 14, 2023
Comment on lines
114
to
119
| auto it = seenNetworks.find(ssid); | ||
| if (it != seenNetworks.end()) { | ||
| if (it.value().connected != ConnectedType::DISCONNECTED || it.value().strength >= strength) { | ||
| continue; | ||
| } | ||
| } |
There was a problem hiding this comment.
are you sure this uses the max signal strength and still updates the connected status? if it's connected, it will always continue and never update the strength. perhaps we just update the Network in each section of this for loop.
There was a problem hiding this comment.
seenNetworks is cleared before loop. all items in it are update-to-date. never mind.I misunderstood
sshane
reviewed
Aug 14, 2023
sshane
reviewed
Aug 14, 2023
sshane
reviewed
Aug 14, 2023
sshane
reviewed
Aug 14, 2023
sshane
reviewed
Aug 14, 2023
…t_skip_connected_network
sshane
reviewed
Aug 17, 2023
|
|
||
| SecurityType security = getSecurityType(properties); | ||
| ConnectedType ctype = ConnectedType::DISCONNECTED; | ||
| seenNetworks[ssid].security_type = getSecurityType(properties); | ||
| if (path.path() == activeAp) { |
There was a problem hiding this comment.
@deanlee looks like this is only true for the current access point, right? If so, does my change LGTY?
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #28688