Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN: update driver braking signal #30424

Merged
merged 4 commits into from Nov 10, 2023
Merged

Hyundai CAN: update driver braking signal #30424

merged 4 commits into from Nov 10, 2023

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Nov 9, 2023

Over 100k random Hyundai segments last year, this new signal never doesn't catch brake presses. There are a few cases where it catches new brake presses which I'll categorize below:

@sshane sshane added car vehicle-specific hyundai labels Nov 9, 2023
@sshane sshane changed the title Hyundai CAN: use driver braking signal that includes regen braking Hyundai CAN: update driver braking signal Nov 9, 2023
@sshane
Copy link
Contributor Author

sshane commented Nov 10, 2023

Checked this data last 360 days:

View
Checked segments: 129789, dongles: 476 platforms: {'HYUNDAI PALISADE 2020': 25934, 'KIA NIRO EV 2020': 12025, 'KIA FORTE E 2018 & GT 2021': 330, 'HYUNDAI SONATA 2020': 30184, 'HYUNDAI SANTA FE 2019': 9190, 'KIA STINGER GT2 2018': 2472, 'HYUNDAI IONIQ PHEV 2020': 2902, 'HYUNDAI SANTA FE 2022': 6592, 'GENESIS G80 2017': 942, 'KIA OPTIMA 4TH GEN FACELIFT': 5034, 'HYUNDAI SONATA HYBRID 2021': 5746, 'GENESIS G70 2018': 1954, 'HYUNDAI KONA ELECTRIC 2019': 2899, 'HYUNDAI SANTA FE PlUG-IN HYBRID 2022': 2633, 'HYUNDAI SANTA FE HYBRID 2022': 2011, 'HYUNDAI SONATA 2019': 3788, 'HYUNDAI ELANTRA 2021': 5018, 'HYUNDAI ELANTRA HYBRID 2021': 2796, 'HYUNDAI IONIQ HYBRID 2020-2022': 78, 'KIA K5 2021': 707, 'HYUNDAI IONIQ HYBRID 2017-2019': 144, 'HYUNDAI IONIQ ELECTRIC 2020': 647, 'HYUNDAI KONA HYBRID 2020': 45, 'KIA CEED INTRO ED 2019': 9, 'HYUNDAI IONIQ ELECTRIC LIMITED 2019': 751, 'KIA NIRO HYBRID 2021': 1008, 'KIA STINGER 2022': 618, 'HYUNDAI ELANTRA 2017': 1014, 'KIA SORENTO GT LINE 2018': 556, 'KIA NIRO HYBRID 2019': 200, 'HYUNDAI GENESIS 2015-2016': 1254, 'KIA SELTOS 2021': 66, 'HYUNDAI KONA ELECTRIC 2022': 140, 'KIA K5 HYBRID 2020': 50, 'HYUNDAI AZERA HYBRID 6TH GEN': 4, 'HYUNDAI TUCSON 2019': 10, 'GENESIS G70 2020': 27, 'HYUNDAI I30 N LINE 2019 & GT 2018 DCT': 11}

The largest mismatch type are EV cars where the user depresses the brake pedal enough for the regen braking to kick in, but not enough for the friction brakes.

View Plots
. .
image image
image image
image image

Second largest type are ICE cars like Sonata or Palisade where the user brakes while it's already engaged and actively braking to a stop with wound up brake pressure, it's not enough to trigger the DriverBraking signal, but shows up in the DriverOverride signal. DriverBraking seems to be whether user is adding additional friction brake pressure to the system, while DriverOverride is more closely correlated to brake depressed status.

View Plots
. .
image image
image image

Third largest type of mismatch is a certain Kia Forte dongle that is mismatched by around 10 to 20 frames each segment.

View Plots
. .
image image
image image

The last type of mismatch is tiny time based mismatches where the new signal triggers earlier and falls later due to the lower threshold that shows up as 10-20 frames of mismatch each segment.

View Plots
. .
image image
image image

@sshane sshane merged commit e94c3c5 into master Nov 10, 2023
22 of 23 checks passed
@sshane sshane deleted the hkg-driver-override branch November 10, 2023 09:20
scott0129 pushed a commit to scott0129/openpilot-1 that referenced this pull request Nov 17, 2023
scott0129 pushed a commit to scott0129/openpilot-1 that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyundai CAN (EV): TCS13->DriverBraking doesn't describe brake pedal depressed status
1 participant