Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexus LC 2024 #31199

Merged
merged 7 commits into from
Feb 7, 2024
Merged

Lexus LC 2024 #31199

merged 7 commits into from
Feb 7, 2024

Conversation

nelsonjchen
Copy link
Contributor

@nelsonjchen nelsonjchen commented Jan 28, 2024

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 4765fbbf59e3cd88/2024-02-04--20-20-03
  • route with stock system: 4765fbbf59e3cd88|2024-01-30--14-31-23
  • car harness used (if comma doesn't sell it, put N/A): Toyota A

Copy link
Contributor

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

@github-actions github-actions bot added in-bot-review car vehicle-specific labels Jan 28, 2024
@nelsonjchen nelsonjchen marked this pull request as ready for review February 5, 2024 18:19
@nelsonjchen nelsonjchen marked this pull request as draft February 6, 2024 06:39
@nelsonjchen
Copy link
Contributor Author

Need to add a more anonymous route that can be fully public

@sshane
Copy link
Contributor

sshane commented Feb 6, 2024

Need to add a more anonymous route that can be fully public

@jnewb1 do we strip new routes.py routes yet?

@nelsonjchen
Copy link
Contributor Author

In the meantime, I've asked the owner to purposefully make an anonymousey route:

https://discord.com/channels/469524606043160576/1194100053879558225/1204160481883979887

@nelsonjchen
Copy link
Contributor Author

nelsonjchen commented Feb 7, 2024

OK, we produced a good public-able route. Please copy 4765fbbf59e3cd88|2024-02-06--17-45-32 to the bucket.

@jnewb1
Copy link
Contributor

jnewb1 commented Feb 7, 2024

Need to add a more anonymous route that can be fully public

@jnewb1 do we strip new routes.py routes yet?

no, I think we will want to move this to an automated job eventually... but I added the route

@adeebshihadeh adeebshihadeh merged commit 879e252 into commaai:master Feb 7, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific in-bot-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants