Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nissan: use bus 0 to fingerprint #31243

Merged
merged 4 commits into from Feb 1, 2024
Merged

Nissan: use bus 0 to fingerprint #31243

merged 4 commits into from Feb 1, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jan 31, 2024

Closes: #25755

Follow up to #31138

Once we go to release we'll get a lot more data and can merge

  • NISSAN X-TRAIL 2017 - everything comes back! fa9224be239005c7|2024-01-31--17-57-19
  • NISSAN LEAF 2018 - everything comes back! 289d318fded3221a|2024-01-31--17-35-48
  • NISSAN LEAF 2018 Instrument Cluster - probably works
  • NISSAN ROGUE 2019
  • NISSAN ALTIMA 2020

@sshane sshane marked this pull request as draft January 31, 2024 11:14
@github-actions github-actions bot added car vehicle-specific nissan labels Jan 31, 2024
@sshane sshane marked this pull request as ready for review February 1, 2024 02:02
@sshane
Copy link
Contributor Author

sshane commented Feb 1, 2024

We still have CAN fingerprints, so it's likely cars will fall back if there's problems with this. Will merge now and monitor cars that try master until the release @adeebshihadeh

@sshane
Copy link
Contributor Author

sshane commented Feb 1, 2024

Actually I can check if the responses are on bus 0 as well as bus 1 from old routes (high likelihood we can query from bus 0 as well).

  • Rogue: I see everything but the gateway on bus 0, but we don't have any fingerprints in the DB. e580443912a56219|2024-01-31--16-56-04

@sshane sshane merged commit 7222eb3 into master Feb 1, 2024
26 checks passed
@sshane sshane deleted the nissan-bus-0 branch February 1, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nissan: query FW versions on non-OBD bus
1 participant