Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM: Remove Equinox from dashcam mode #31257

Merged
merged 29 commits into from Feb 13, 2024
Merged

GM: Remove Equinox from dashcam mode #31257

merged 29 commits into from Feb 13, 2024

Conversation

nworb-cire
Copy link
Contributor

@nworb-cire nworb-cire commented Feb 1, 2024

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: e746f59bc96fd789|2024-01-31--21-50-51
  • route with stock system: e746f59bc96fd789|2024-01-31--22-11-28
  • car harness used (if comma doesn't sell it, put N/A): GM camera

selfdrive/car/gm/carstate.py Outdated Show resolved Hide resolved
Co-authored-by: Shane Smiskol <shane@smiskol.com>
@nworb-cire
Copy link
Contributor Author

I added the test route that the user provided while using OP long. I can swap it for a route with stock long if that's preferred.

@nworb-cire nworb-cire marked this pull request as ready for review February 1, 2024 04:34
@nan0AI
Copy link

nan0AI commented Feb 1, 2024

Test routes as requested:

https://connect.comma.ai/e746f59bc96fd789/1706755851269/1706756236057
Route (default openpilot controls)

https://connect.comma.ai/e746f59bc96fd789/1706757088554/1706757724406
Route(default vehicle stock acc controls)

https://connect.comma.ai/e746f59bc96fd789/1706757957709/1706758491747
Route(alpha longitudinal controls , this needs work)

@nworb-cire
Copy link
Contributor Author

The only CI failure is this: AssertionError: False is not true : Route not on CI bucket. This is fine to fail for WIP car ports, just let us know and we can upload your routes to the CI bucket. @sshane are we good to go once you get this route uploaded?

@sshane
Copy link
Contributor

sshane commented Feb 13, 2024

thanks!

@sshane sshane merged commit 416e825 into commaai:master Feb 13, 2024
25 checks passed
@nworb-cire nworb-cire deleted the equinox branch February 13, 2024 15:25
@Verylukyguy
Copy link
Contributor

The user that provided the fingerprint and test route for this PR actually has a 2020 GMC Terrain, which is a sister vehicle to the Equinox and is on the same chassis and platform.

@sshane
Copy link
Contributor

sshane commented Feb 20, 2024

That's not what their VIN reports:

image

@nan0AI
Copy link

nan0AI commented Feb 20, 2024

That's not what their VIN reports:

image

I have a Chevrolet Equinox, another user has a GMC Terrain and got it to work via Frog Pilot Fork. Like you guys said though, it's the same vehicle with a different brand so it should be compatible as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants