Calibration Transform: border pad #31495
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchybicki
pushed a commit
to rchybicki/openpilot
that referenced
this pull request
Feb 17, 2024
AlexandreSato
pushed a commit
to AlexandreSato/openpilot
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the camera points far enough up (true on many sedans), there is not enough FOV to show the image the model expects. So a part is out of bounds. During training this is padded, at runtime it is filled with zeros (in YUV so it looks green). This discrepancy causes some loss in performance, this PR implements the same border padding at runtime that we use at traintime.