Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN FD: allow more platforms to use enhanced fuzzy fingerprinting #31882

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 15, 2024

Allowed by detecting hybrid here: #31237

Expands on whitelist PR: #31242


Fixes a recent case of non-immediate fingerprinting by a Carnival: ec32d6aa1c7735d1/2024-03-15--16-41-46

We don't have to worry about mixing up the hybrid and ICE variants as we now detect that flag dynamically, the only issue is the mass not being as accurate as possible (but before it would have been a CAN error).

@sshane sshane merged commit 91933b5 into master Mar 15, 2024
27 of 28 checks passed
@sshane sshane deleted the canfd-fuzzy-fp-whitelist branch March 15, 2024 21:46
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
…ting (commaai#31882)

* K8 has hybrid descriptor (GL3H), AND we detect hybrid now

* don't know if Carnival's hybrid variant has them, but it's not out yet, and we detect hybrid

fixes: ec32d6aa1c7735d1/2024-03-15--16-41-46

* cmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant