Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024 IONIQ 6 #32302

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

2024 IONIQ 6 #32302

wants to merge 2 commits into from
+5 −3

Conversation

riley-williams
Copy link

@riley-williams riley-williams commented Apr 27, 2024 •
edited

Car

US 2024 IONIQ 6 (Limited AWD tested)

Checklist

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot:
  • route with stock system:
  • car harness used: Hyundai P

Notes

  • Minor tweaks to CarSpecs for IONIQ 6 reflect public info instead of cloning the subtly different IONIQ 5 specs
  • Both model years have identical fingerprints, and the '24 is currently ID'd as a '23. The marketing materials for the two model years also seem to have no differences.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 27, 2024 •
edited

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added car vehicle-specific hyundai labels Apr 27, 2024
@riley-williams riley-williams changed the title IONIQ 6 2024 IONIQ 6 Apr 27, 2024
riley-williams
riley-williams commented Apr 27, 2024
View reviewed changes
selfdrive/car/hyundai/values.py
[HyundaiCarDocs("Hyundai Ioniq 6 (with HDA II) 2023-24", "Highway Driving Assist II", car_parts=CarParts.common([CarHarness.hyundai_p]))],
# Average of min/max mass of SEL/LTD models. Significantly lighter SE Standard Range should be uncommon
# https://www.hyundainews.com/assets/documents/original/53031-2023IONIQ6ProductSpecs093022.pdf
CarSpecs(mass=2004, wheelbase=2.95, steerRatio=14.27, tireStiffnessFactor=0.65),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expand up to see old values in IONIQ 5. Not sure if this is the right way to pick a weight, or what effect it has. The IONIQ 5 is heavier, but it looks like a value on the lower side was picked.

@sshane
Copy link
Contributor

sshane commented May 22, 2024

This good to go?

@sshane
Copy link
Contributor

sshane commented May 22, 2024

I don't see any 2024s in our data, but a lot of routes are missing the VIN due to some issue in the comma power (we should figure out how to get the VIN without that). Do you have a route of a 2024?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car vehicle-specific hyundai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riley-williams @sshane