Volt: Pseudo-Fix for acceleration bug #342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from comma devel
merge from comma
|
@Jamezz I see that PCM faults out before GasRegenCmdActive becomes 1. I also noticed that we start sending ACCCmdActive = 1 (ASCMActiveCruiseControlStatus) sooner than GasRegenCmdActive, and AcceleratorPedal2:CruiseState faults out (becomes 3) soon after ACCCmdActive sent as 1. Upd: they are set from the same 'cc.enabled' bit, never mind (my cabana log looks inconsistent). |
|
Going on a test ride with a GM-only workaround, |
|
Posted a GM-only version of doing the same as PR 348, in case it's undesirable to affect other cars. |
|
merged @vntarasov version. Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Probably not real fix, just demonstrating)
The Volt's PCM does not enter ACC mode properly if you stay in pre-enabled state while sending ZERO_GAS. When you transition from pre-enabled -> enabled and try to send gas, the PCM faults out (intermittently) and refuses to provide acceleration. Disengaging and reengaging can sometimes fix this.
We should only be sending GasRegenCmdActive=1 in the ASCMGasRegenCmd when actuators are enabled (active)