Fix pre-enable engagement on GM #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas is commanded while user presses gas pedal. PID winds up, and when PCM fault clears, car gets a "max gas" jolt. In 2018 Volts, PCM fault doesn't time out, which means pre-enable doesn't work at all, and car would slowly decelerate, while openpilot thinks it's engaged.
energee
pushed a commit
to energee/openpilot
that referenced
this pull request
Sep 12, 2018
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas is commanded while user presses gas pedal. PID winds up, and when PCM fault clears, car gets a "max gas" jolt. In 2018 Volts, PCM fault doesn't time out, which means pre-enable doesn't work at all, and car would slowly decelerate, while openpilot thinks it's engaged.
|
Fix didn't work for me, 2018 Volt. OP engages when foot is taken off the throttle, but car continues to slow down. Lateral control continues to work. |
DavidWAbrahams
pushed a commit
to jeankalud/openpilot
that referenced
this pull request
Sep 26, 2018
Squashed commit of the following:
commit e5c1762d8d34775bdab90b3a57a5d8c1be1aa546
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 19:57:03 2018 +0000
ACC: (follow mode) don't autoresume if speed has dipped below min
commit b10684bd41849c6fef1e0b69b4b73be83c361cbc
Merge: 88854d7 6e14326
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 18:59:58 2018 +0000
Merge branch 'tesla_devel' into cruise_devel
commit 6e143265aced07dcb519b32349c5d37fd228979d
Author: BogGyver <39277124+BogGyver@users.noreply.github.com>
Date: Tue Sep 18 14:44:28 2018 -0400
using EPAS_internalSAS (Steering Angle Sensor) instead of StW_AnglHP to detect angle
by switching from Steering Wheel Angle to the internal EPAS sensor for angle we hope to automatically compensate for road crown and alignment issues
commit 88854d7080b601481274dbec84a679dead191c9f
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 04:48:48 2018 +0000
ACC: Wait longer before accel when lead is lost
commit 4d53683e41907e862c15d9512212084a7918eeba
Merge: d2ae6bf f4192fc
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 04:43:27 2018 +0000
Merge branch 'tesla_devel' into cruise_devel
commit f4192fcbdeecaafb1b6a149f168cd25b32f9fc47
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 04:42:33 2018 +0000
GPS display fix and cruise full-regen brake improvements
Squashed commit of the following:
commit d2ae6bff5962ab1a514b823ec74734d1fbb86ec1
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 04:40:28 2018 +0000
ACC: delete invalid variable reference
commit 3cd0cca4dcc120666eae504139d8aad71cf59a67
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 00:55:57 2018 +0000
bbui build fix
commit 97cbdae3e80c5b15fddc3e8b2b1e79cd7395795c
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 00:51:44 2018 +0000
bbui build fix
commit 2351afafef69e10d3b826a863d94e5beb3e7a020
Author: BogGyver <bogdan.butoi@gmail.com>
Date: Mon Sep 17 15:49:03 2018 -0400
Cherrypick from @BogGyver to fix GPS accuracy
commit bf194000d36e942db3b2ea7dac262d710c242c33
Author: BogGyver <bogdan.butoi@gmail.com>
Date: Mon Sep 17 17:00:36 2018 -0400
reenabled driver monitoring icon
commit b94619193042bc38ea53ee87e6126ed22f86505d
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 21:34:43 2018 +0000
Fix GPS precision display
commit 4cb6440b2832a2bcebe2ef84d82e7722cad0a978
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 18:44:51 2018 +0000
ACC: Fix button color when enabled
commit 64a754b06b9a0f85013264b64443ecfac8298d96
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 18:34:19 2018 +0000
ACC: Better auto-resume after full regen braking
commit 53a821461e039ab9ed218f6e92e649967861fb5d
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 17:08:19 2018 +0000
ACC: syntax fix
commit b37840b805a492424602f93e949f85d4fc96d873
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 05:16:37 2018 +0000
ACC: Only human brake use disables ACC. Will attempt to resume otherwise.
commit 2ce10048f63d9dcd87375bb11bb8af8b19e1d5e7
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 07:25:03 2018 +0000
ACC: increase window for resuming from fast decel
commit 2a7f56bedd5727043fbe560757ff9ee32fb53777
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 07:16:18 2018 +0000
ACC: fast decel and resume for both ACC modes
commit b31328436a1fb7a30aa7c21fb2e8d72b5c13e3b1
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 03:43:41 2018 +0000
Fix odd race codition in UI button creation
commit 097404ebdc457645f1e00eca07735fe184bfc7f4
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 02:04:35 2018 +0000
ACC: Time limit for logic to abort fast stopping
commit d36ddaf6ca14aec20332675098c66770a3bba931
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 00:33:57 2018 +0000
ACC: Allow auto-cancel of auto-fast-stops
commit 8e09321a57bf8f4fe48d9b2f062f4e5c11cf5122
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:29:11 2018 +0000
ACC: button syntax fixes
commit 493f45cba404a9177c884229ff494f0c92ae5a7b
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:25:36 2018 +0000
ACC: button syntax fix
commit 226fe3295a29509cd8779861ebefaf54d45e9ef7
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:20:09 2018 +0000
ACC: button syntax fixes
commit 844c0a5ef28028628cf9adc4ab679c6f6ce1b966
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:29:17 2018 +0000
ACC: Button state fix
commit d35b16aec1a3f81275b7b658d4e62d20c1ef4d67
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:25:14 2018 +0000
ACC: Simplify button state code
commit 3a0805c4f8c9f38c7503cc9bea0041b0534a6836
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:21:29 2018 +0000
ACC: Allow UI button to disable ACC
commit 509c92d706cb9f04a0ec1120217d66553ec2b1cc
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 23:23:23 2018 +0000
ACC: Check for cruise disengage even if buttons are being pressed
commit 579550b338b0b107d65bc67c3c3c927845db8383
Merge: 3309818 fd1064b
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 01:14:28 2018 +0000
Merge branch 'tesla_devel' into cruise_devel
commit 3309818547b386086ffdf22263659926f4bf395f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 03:09:00 2018 +0000
ACC: Attempt to fix bug that prevents ACC autoresume during accel
commit 94b2908e9bb9d0b5d5cf7c1fcc7c69bab0d35d9f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 01:12:11 2018 +0000
ACC: shrink autoengage method signature
commit a595a0bd57284b9e1704a435add9961f5f2643ee
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:36:59 2018 +0000
ACC: whitespace
commit dd2cc01ee6696387341c4c70ebe07f4241f2dd69
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:33:01 2018 +0000
ACC: refactor for smaller, private methods
commit bf22269f0b605d8db83781aed98877e0163ac2ad
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 21:05:46 2018 +0000
ACC: prioritize decel over accel
commit aee5f7d83f1353e978a792d227ceb3336db40290
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:59:00 2018 +0000
ACC: comments
commit 17fdcc61619f70d82d9a2e39e58e1a525225bee3
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:41:06 2018 +0000
ACC: don't compete with human-issued commands
commit 6d272d66122e54b4807d32293a8bb5c2813bd235
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:19:18 2018 +0000
ACC: Correct rate limit logic
commit 7bac0d18c1d6fb68edc928745ce3de44926a0145
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:16:16 2018 +0000
ACC: Comments
commit 2ee635a3e568ba3955e9f9b95d248e926b8cfd21
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:09:04 2018 +0000
ACC: Clean up command rate limit code
commit 7e8c3cb296171729d54aee512e6f3539a29ebd78
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 19:32:47 2018 +0000
ACC: tighten max follow distance
commit 185769d130c3bd06decf70300ea35bf535d38c12
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:49:21 2018 +0000
ACC: Fix units on a check for stopped traffic
commit 0ed681ec57640d80dbd57d55cd19e97b3e35db5e
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:45:53 2018 +0000
ACC: adding units to variable names (kpm, m, s, etc)
commit f981686212f62f34a77deedcd863e76ff47aa214
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:41:07 2018 +0000
ACC: More eager to accel if lead car is pulling away
commit c489e6138e31ee7b995bb9893f5c6f1045a94486
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:38:53 2018 +0000
ACC: No rate-limiter if a rapid stop is needed
commit 7c9d97b97e59a86c9558844018728293aa9b21a9
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 01:54:31 2018 +0000
ACC: more gradual approach to slow lead cars
commit d2ae6bff5962ab1a514b823ec74734d1fbb86ec1
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 04:40:28 2018 +0000
ACC: delete invalid variable reference
commit 3cd0cca4dcc120666eae504139d8aad71cf59a67
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 00:55:57 2018 +0000
bbui build fix
commit 97cbdae3e80c5b15fddc3e8b2b1e79cd7395795c
Author: David Abrahams <you@example.com>
Date: Tue Sep 18 00:51:44 2018 +0000
bbui build fix
commit 2351afafef69e10d3b826a863d94e5beb3e7a020
Author: BogGyver <bogdan.butoi@gmail.com>
Date: Mon Sep 17 15:49:03 2018 -0400
Cherrypick from @BogGyver to fix GPS accuracy
commit bf194000d36e942db3b2ea7dac262d710c242c33
Author: BogGyver <bogdan.butoi@gmail.com>
Date: Mon Sep 17 17:00:36 2018 -0400
reenabled driver monitoring icon
commit b94619193042bc38ea53ee87e6126ed22f86505d
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 21:34:43 2018 +0000
Fix GPS precision display
commit 4cb6440b2832a2bcebe2ef84d82e7722cad0a978
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 18:44:51 2018 +0000
ACC: Fix button color when enabled
commit 64a754b06b9a0f85013264b64443ecfac8298d96
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 18:34:19 2018 +0000
ACC: Better auto-resume after full regen braking
commit 53a821461e039ab9ed218f6e92e649967861fb5d
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 17:08:19 2018 +0000
ACC: syntax fix
commit b37840b805a492424602f93e949f85d4fc96d873
Author: David Abrahams <you@example.com>
Date: Mon Sep 17 05:16:37 2018 +0000
ACC: Only human brake use disables ACC. Will attempt to resume otherwise.
commit 2ce10048f63d9dcd87375bb11bb8af8b19e1d5e7
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 07:25:03 2018 +0000
ACC: increase window for resuming from fast decel
commit 2a7f56bedd5727043fbe560757ff9ee32fb53777
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 07:16:18 2018 +0000
ACC: fast decel and resume for both ACC modes
commit 5a10dc17c7df9e6de14677951960c60070d2b708
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 06:59:15 2018 +0000
ACC: button fix and auto-resume from some full-regen braking situations
commit b31328436a1fb7a30aa7c21fb2e8d72b5c13e3b1
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 03:43:41 2018 +0000
Fix odd race codition in UI button creation
commit 097404ebdc457645f1e00eca07735fe184bfc7f4
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 02:04:35 2018 +0000
ACC: Time limit for logic to abort fast stopping
commit d36ddaf6ca14aec20332675098c66770a3bba931
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 00:33:57 2018 +0000
ACC: Allow auto-cancel of auto-fast-stops
commit 8e09321a57bf8f4fe48d9b2f062f4e5c11cf5122
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:29:11 2018 +0000
ACC: button syntax fixes
commit 493f45cba404a9177c884229ff494f0c92ae5a7b
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:25:36 2018 +0000
ACC: button syntax fix
commit 226fe3295a29509cd8779861ebefaf54d45e9ef7
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:20:09 2018 +0000
ACC: button syntax fixes
commit 844c0a5ef28028628cf9adc4ab679c6f6ce1b966
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:29:17 2018 +0000
ACC: Button state fix
commit d35b16aec1a3f81275b7b658d4e62d20c1ef4d67
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:25:14 2018 +0000
ACC: Simplify button state code
commit 3a0805c4f8c9f38c7503cc9bea0041b0534a6836
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:21:29 2018 +0000
ACC: Allow UI button to disable ACC
commit 509c92d706cb9f04a0ec1120217d66553ec2b1cc
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 23:23:23 2018 +0000
ACC: Check for cruise disengage even if buttons are being pressed
commit 579550b338b0b107d65bc67c3c3c927845db8383
Merge: 3309818 fd1064b
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 01:14:28 2018 +0000
Merge branch 'tesla_devel' into cruise_devel
commit 3309818547b386086ffdf22263659926f4bf395f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 03:09:00 2018 +0000
ACC: Attempt to fix bug that prevents ACC autoresume during accel
commit 94b2908e9bb9d0b5d5cf7c1fcc7c69bab0d35d9f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 01:12:11 2018 +0000
ACC: shrink autoengage method signature
commit a595a0bd57284b9e1704a435add9961f5f2643ee
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:36:59 2018 +0000
ACC: whitespace
commit dd2cc01ee6696387341c4c70ebe07f4241f2dd69
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:33:01 2018 +0000
ACC: refactor for smaller, private methods
commit bf22269f0b605d8db83781aed98877e0163ac2ad
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 21:05:46 2018 +0000
ACC: prioritize decel over accel
commit aee5f7d83f1353e978a792d227ceb3336db40290
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:59:00 2018 +0000
ACC: comments
commit 17fdcc61619f70d82d9a2e39e58e1a525225bee3
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:41:06 2018 +0000
ACC: don't compete with human-issued commands
commit 6d272d66122e54b4807d32293a8bb5c2813bd235
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:19:18 2018 +0000
ACC: Correct rate limit logic
commit 7bac0d18c1d6fb68edc928745ce3de44926a0145
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:16:16 2018 +0000
ACC: Comments
commit 2ee635a3e568ba3955e9f9b95d248e926b8cfd21
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:09:04 2018 +0000
ACC: Clean up command rate limit code
commit 7e8c3cb296171729d54aee512e6f3539a29ebd78
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 19:32:47 2018 +0000
ACC: tighten max follow distance
commit 185769d130c3bd06decf70300ea35bf535d38c12
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:49:21 2018 +0000
ACC: Fix units on a check for stopped traffic
commit 0ed681ec57640d80dbd57d55cd19e97b3e35db5e
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:45:53 2018 +0000
ACC: adding units to variable names (kpm, m, s, etc)
commit f981686212f62f34a77deedcd863e76ff47aa214
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:41:07 2018 +0000
ACC: More eager to accel if lead car is pulling away
commit c489e6138e31ee7b995bb9893f5c6f1045a94486
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:38:53 2018 +0000
ACC: No rate-limiter if a rapid stop is needed
commit 7c9d97b97e59a86c9558844018728293aa9b21a9
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 01:54:31 2018 +0000
ACC: more gradual approach to slow lead cars
commit b31328436a1fb7a30aa7c21fb2e8d72b5c13e3b1
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 03:43:41 2018 +0000
Fix odd race codition in UI button creation
commit 097404ebdc457645f1e00eca07735fe184bfc7f4
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 02:04:35 2018 +0000
ACC: Time limit for logic to abort fast stopping
commit d36ddaf6ca14aec20332675098c66770a3bba931
Author: David Abrahams <you@example.com>
Date: Sun Sep 16 00:33:57 2018 +0000
ACC: Allow auto-cancel of auto-fast-stops
commit c1386a30096de4ee5273c33e7e7c64f20a103e52
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 05:10:44 2018 +0000
Add ability to disable ACC via UI button
Squashed commit of the following:
commit 8e09321a57bf8f4fe48d9b2f062f4e5c11cf5122
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:29:11 2018 +0000
ACC: button syntax fixes
commit 493f45cba404a9177c884229ff494f0c92ae5a7b
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:25:36 2018 +0000
ACC: button syntax fix
commit 226fe3295a29509cd8779861ebefaf54d45e9ef7
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:20:09 2018 +0000
ACC: button syntax fixes
commit 844c0a5ef28028628cf9adc4ab679c6f6ce1b966
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:29:17 2018 +0000
ACC: Button state fix
commit d35b16aec1a3f81275b7b658d4e62d20c1ef4d67
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:25:14 2018 +0000
ACC: Simplify button state code
commit 3a0805c4f8c9f38c7503cc9bea0041b0534a6836
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:21:29 2018 +0000
ACC: Allow UI button to disable ACC
commit 509c92d706cb9f04a0ec1120217d66553ec2b1cc
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 23:23:23 2018 +0000
ACC: Check for cruise disengage even if buttons are being pressed
commit 579550b338b0b107d65bc67c3c3c927845db8383
Merge: 3309818 fd1064b
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 01:14:28 2018 +0000
Merge branch 'tesla_devel' into cruise_devel
commit 3309818547b386086ffdf22263659926f4bf395f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 03:09:00 2018 +0000
ACC: Attempt to fix bug that prevents ACC autoresume during accel
commit 94b2908e9bb9d0b5d5cf7c1fcc7c69bab0d35d9f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 01:12:11 2018 +0000
ACC: shrink autoengage method signature
commit a595a0bd57284b9e1704a435add9961f5f2643ee
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:36:59 2018 +0000
ACC: whitespace
commit dd2cc01ee6696387341c4c70ebe07f4241f2dd69
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:33:01 2018 +0000
ACC: refactor for smaller, private methods
commit bf22269f0b605d8db83781aed98877e0163ac2ad
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 21:05:46 2018 +0000
ACC: prioritize decel over accel
commit aee5f7d83f1353e978a792d227ceb3336db40290
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:59:00 2018 +0000
ACC: comments
commit 17fdcc61619f70d82d9a2e39e58e1a525225bee3
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:41:06 2018 +0000
ACC: don't compete with human-issued commands
commit 6d272d66122e54b4807d32293a8bb5c2813bd235
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:19:18 2018 +0000
ACC: Correct rate limit logic
commit 7bac0d18c1d6fb68edc928745ce3de44926a0145
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:16:16 2018 +0000
ACC: Comments
commit 2ee635a3e568ba3955e9f9b95d248e926b8cfd21
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:09:04 2018 +0000
ACC: Clean up command rate limit code
commit 7e8c3cb296171729d54aee512e6f3539a29ebd78
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 19:32:47 2018 +0000
ACC: tighten max follow distance
commit 185769d130c3bd06decf70300ea35bf535d38c12
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:49:21 2018 +0000
ACC: Fix units on a check for stopped traffic
commit 0ed681ec57640d80dbd57d55cd19e97b3e35db5e
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:45:53 2018 +0000
ACC: adding units to variable names (kpm, m, s, etc)
commit f981686212f62f34a77deedcd863e76ff47aa214
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:41:07 2018 +0000
ACC: More eager to accel if lead car is pulling away
commit c489e6138e31ee7b995bb9893f5c6f1045a94486
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:38:53 2018 +0000
ACC: No rate-limiter if a rapid stop is needed
commit 7c9d97b97e59a86c9558844018728293aa9b21a9
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 01:54:31 2018 +0000
ACC: more gradual approach to slow lead cars
commit 8e09321a57bf8f4fe48d9b2f062f4e5c11cf5122
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:29:11 2018 +0000
ACC: button syntax fixes
commit 493f45cba404a9177c884229ff494f0c92ae5a7b
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:25:36 2018 +0000
ACC: button syntax fix
commit 226fe3295a29509cd8779861ebefaf54d45e9ef7
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 01:20:09 2018 +0000
ACC: button syntax fixes
commit 844c0a5ef28028628cf9adc4ab679c6f6ce1b966
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:29:17 2018 +0000
ACC: Button state fix
commit d35b16aec1a3f81275b7b658d4e62d20c1ef4d67
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:25:14 2018 +0000
ACC: Simplify button state code
commit 3a0805c4f8c9f38c7503cc9bea0041b0534a6836
Author: David Abrahams <you@example.com>
Date: Sat Sep 15 00:21:29 2018 +0000
ACC: Allow UI button to disable ACC
commit 509c92d706cb9f04a0ec1120217d66553ec2b1cc
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 23:23:23 2018 +0000
ACC: Check for cruise disengage even if buttons are being pressed
commit 579550b338b0b107d65bc67c3c3c927845db8383
Merge: 3309818 fd1064b
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 01:14:28 2018 +0000
Merge branch 'tesla_devel' into cruise_devel
commit fd1064b3b056b37a19c1317d604872aef55cba65
Author: David Abrahams <you@example.com>
Date: Fri Sep 14 01:12:12 2018 +0000
Revert "ACC: Attempt to clear saved CC speed when ACC disengages"
This reverts commit d4a5aa58c602c03c21afcc3bcaf658d4e42141d6.
commit d4a5aa58c602c03c21afcc3bcaf658d4e42141d6
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 23:30:28 2018 +0000
ACC: Attempt to clear saved CC speed when ACC disengages
commit 6d05326fa21866b765e4c6c778b01f57b038a240
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 17:36:36 2018 +0000
ACC overhaul:
* More sensitive detection of stopped traffic
* gradual approach to a slower lead car
* More eager to accel if lead car is pulling away
* Encapsulate logic into helper methods
Squashed commit of the following:
commit 3309818547b386086ffdf22263659926f4bf395f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 03:09:00 2018 +0000
ACC: Attempt to fix bug that prevents ACC autoresume during accel
commit 94b2908e9bb9d0b5d5cf7c1fcc7c69bab0d35d9f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 01:12:11 2018 +0000
ACC: shrink autoengage method signature
commit a595a0bd57284b9e1704a435add9961f5f2643ee
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:36:59 2018 +0000
ACC: whitespace
commit dd2cc01ee6696387341c4c70ebe07f4241f2dd69
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:33:01 2018 +0000
ACC: refactor for smaller, private methods
commit bf22269f0b605d8db83781aed98877e0163ac2ad
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 21:05:46 2018 +0000
ACC: prioritize decel over accel
commit aee5f7d83f1353e978a792d227ceb3336db40290
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:59:00 2018 +0000
ACC: comments
commit 17fdcc61619f70d82d9a2e39e58e1a525225bee3
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:41:06 2018 +0000
ACC: don't compete with human-issued commands
commit 6d272d66122e54b4807d32293a8bb5c2813bd235
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:19:18 2018 +0000
ACC: Correct rate limit logic
commit 7bac0d18c1d6fb68edc928745ce3de44926a0145
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:16:16 2018 +0000
ACC: Comments
commit 2ee635a3e568ba3955e9f9b95d248e926b8cfd21
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:09:04 2018 +0000
ACC: Clean up command rate limit code
commit 7e8c3cb296171729d54aee512e6f3539a29ebd78
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 19:32:47 2018 +0000
ACC: tighten max follow distance
commit 185769d130c3bd06decf70300ea35bf535d38c12
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:49:21 2018 +0000
ACC: Fix units on a check for stopped traffic
commit 0ed681ec57640d80dbd57d55cd19e97b3e35db5e
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:45:53 2018 +0000
ACC: adding units to variable names (kpm, m, s, etc)
commit f981686212f62f34a77deedcd863e76ff47aa214
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:41:07 2018 +0000
ACC: More eager to accel if lead car is pulling away
commit c489e6138e31ee7b995bb9893f5c6f1045a94486
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:38:53 2018 +0000
ACC: No rate-limiter if a rapid stop is needed
commit 7c9d97b97e59a86c9558844018728293aa9b21a9
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 01:54:31 2018 +0000
ACC: more gradual approach to slow lead cars
commit 3309818547b386086ffdf22263659926f4bf395f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 03:09:00 2018 +0000
ACC: Attempt to fix bug that prevents ACC autoresume during accel
commit 94b2908e9bb9d0b5d5cf7c1fcc7c69bab0d35d9f
Author: David Abrahams <you@example.com>
Date: Thu Sep 13 01:12:11 2018 +0000
ACC: shrink autoengage method signature
commit a595a0bd57284b9e1704a435add9961f5f2643ee
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:36:59 2018 +0000
ACC: whitespace
commit dd2cc01ee6696387341c4c70ebe07f4241f2dd69
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 22:33:01 2018 +0000
ACC: refactor for smaller, private methods
commit bf22269f0b605d8db83781aed98877e0163ac2ad
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 21:05:46 2018 +0000
ACC: prioritize decel over accel
commit aee5f7d83f1353e978a792d227ceb3336db40290
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:59:00 2018 +0000
ACC: comments
commit 17fdcc61619f70d82d9a2e39e58e1a525225bee3
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:41:06 2018 +0000
ACC: don't compete with human-issued commands
commit 6d272d66122e54b4807d32293a8bb5c2813bd235
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:19:18 2018 +0000
ACC: Correct rate limit logic
commit 7bac0d18c1d6fb68edc928745ce3de44926a0145
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:16:16 2018 +0000
ACC: Comments
commit 2ee635a3e568ba3955e9f9b95d248e926b8cfd21
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 20:09:04 2018 +0000
ACC: Clean up command rate limit code
commit 7e8c3cb296171729d54aee512e6f3539a29ebd78
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 19:32:47 2018 +0000
ACC: tighten max follow distance
commit 185769d130c3bd06decf70300ea35bf535d38c12
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:49:21 2018 +0000
ACC: Fix units on a check for stopped traffic
commit 0ed681ec57640d80dbd57d55cd19e97b3e35db5e
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:45:53 2018 +0000
ACC: adding units to variable names (kpm, m, s, etc)
commit f981686212f62f34a77deedcd863e76ff47aa214
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:41:07 2018 +0000
ACC: More eager to accel if lead car is pulling away
commit c489e6138e31ee7b995bb9893f5c6f1045a94486
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 18:38:53 2018 +0000
ACC: No rate-limiter if a rapid stop is needed
commit 7c9d97b97e59a86c9558844018728293aa9b21a9
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 01:54:31 2018 +0000
ACC: more gradual approach to slow lead cars
commit b74f5d435feb51ce89e29187d8e4f53e95a71b78
Merge: 743294c ceb97d9
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 01:34:50 2018 +0000
OpenPilot 0.5.3
Merge branch 'cruise_devel' into tesla_devel
commit ceb97d9b2515785303fb6a71efecf32caca5bd7f
Author: David Abrahams <you@example.com>
Date: Wed Sep 12 00:21:16 2018 +0000
Merge conflict in boardd.cc
commit 28d9d87e9caa35cc3fd944586cf654fa8caeb087
Author: David Abrahams <you@example.com>
Date: Tue Sep 11 22:57:32 2018 +0000
ACC: tighten check for slow traffic
commit 45c00d1d59b3522ecb1e9492cc5e2b0ae6bafe31
Author: David Abrahams <you@example.com>
Date: Tue Sep 11 22:23:09 2018 +0000
ACC: Consider current CC speed before making any changes
commit c7da38712945d77fbc9eb0e614008754989382d8
Author: David Abrahams <you@example.com>
Date: Tue Sep 11 20:19:10 2018 +0000
More readable ACC auto-engage logic
commit cace697870e8982140a6d66daf77ddd90932d649
Merge: da1e131 b3654cb
Author: David Abrahams <you@example.com>
Date: Tue Sep 11 17:39:39 2018 +0000
OpenPilot 0.5.3
Merge remote-tracking branch 'op/devel' into cruise_devel
commit da1e131948dcac78392a6947a101eff23e6a082d
Author: David Abrahams <you@example.com>
Date: Sun Sep 9 23:43:20 2018 +0000
ACC: remove a broken & redundant acceleration limit
commit 743294c0ebfebba9d94d4477c843f1d3df999f2e
Author: David Abrahams <you@example.com>
Date: Sun Sep 9 23:07:13 2018 +0000
ACC refactor
* Better handling of slow traffic
* Prevent some deceleration when a faster car merges into your lane
* Follow the 2 second rule more often
Squashed commit of the following:
commit 69da74686ddb4d15db79e3c6d877d3ad86d25a38
Author: David Abrahams <you@example.com>
Date: Fri Sep 7 17:36:16 2018 +0000
Remove expiermental ACC; it was not successful.
commit 4f87bcf136a701698bf49699152bac820be89abc
Author: David Abrahams <you@example.com>
Date: Fri Sep 7 00:18:45 2018 +0000
ACC: More cautious value for full stops
commit 0b3dbc3904c2fa9abe5a07110fca200be43e34a1
Author: David Abrahams <you@example.com>
Date: Fri Sep 7 00:08:35 2018 +0000
ACC: Further strengthen full-stop logic
commit f04a228f316ab4e0bd54eb815ba1680e6a824188
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 19:01:04 2018 +0000
ACC: syntax fix
commit b9e5a132d644168ac44d3472b4b467f7d59f78e8
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 18:32:57 2018 +0000
ACC: even more readable accel logic
commit e5202d6d7486df90fd22d8ab507c05935654613a
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 18:20:29 2018 +0000
ACC: clean up accel logic
commit 07c0442b28c554166fc16dc5202825a1e7e4163c
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 17:28:30 2018 +0000
ACC: strengthen stopped traffic check
commit 6a9e17a189f50c07dd8220c40693f1cefbc7cee5
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 16:55:06 2018 +0000
ACC syntax fix
commit 01e9e250055f9403e7ed12b80afa60405a4703f9
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 16:53:28 2018 +0000
ACC syntax fix
commit ff6603813051ee44693d74bfa28ce07f17f1b0e5
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 16:51:12 2018 +0000
ACC module tweaks
commit d621f156ffaa1455842a79aa26c033258041719c
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 22:08:57 2018 +0000
ACC comment fix
commit 4e427854385bf4000c411e7d8642e0da8cf9e59e
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 19:14:40 2018 +0000
Prevent accel under safe range in JJ ACC
commit 3984fa02a517840e38af15a32758f0c3c3f3625b
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 19:08:31 2018 +0000
ACC stopped traffic enhancement
commit 933fdc28b86b5c975e6cb9d836312c2af9f55c09
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 18:59:34 2018 +0000
Experimental ACC: cleanup smoothing
commit b91f142a76cdea1128299e851051ef777cdacfd6
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 18:52:24 2018 +0000
ACC: Take existing accel/decel into account in JJ algorithm
commit 9b735811444bf805a4e50f4b7c71c9b2dc701c52
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 16:08:46 2018 +0000
More conservative ACC follow
commit 1f23156b9595e24021d33ba9af37f8cbc9471459
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 15:51:43 2018 +0000
Add stopped traffic to JJ algo
commit 868b006cc384138d82e6d4364b247328672a700c
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 20:21:14 2018 +0000
Experimental ACC: disable smoothing
commit 157862ff9a53f1b701009ad22c4f29d6337642f1
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 20:06:40 2018 +0000
Experimental ACC: fix method signature
commit 7752a47add54a06dedd6ae812a8ce57fa86bed0b
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 20:00:59 2018 +0000
Experimental ACC: divide by zero fix
commit 51fbaac1af2935b5a3c8734cc28a2a3a6c9e6230
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 18:43:35 2018 +0000
Experimental ACC: remove distance smoothing
commit a1200ab234223c62d4f370e0beb1dd2befa79d94
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 18:20:04 2018 +0000
Experimental ACC: Weight speed observations by distance also
commit 72f7016fa20c364b17f823fba5c4e70a1c52d02b
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 18:15:13 2018 +0000
Experimental ACC: correct weight function
commit b9f2dac9c202904ceeb7ce53b4c8330e107e4ac6
Author: George Hotz <george@comma.ai>
Date: Fri Aug 31 18:40:52 2018 -0700
Experimental ACC: fix unit conversion
commit f586e4ecf73475de77ecb310f1c295f55bd58b58
Author: David Abrahams <you@example.com>
Date: Sat Sep 1 00:01:42 2018 +0000
Experimental ACC: don't smooth distance
commit 184bf60e1fd254faf31e1b7fa3124780e60e68bd
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 23:43:40 2018 +0000
Experimental ACC: isolate smoothing logic into a class
commit 719d984d8e5320315aab7362fe3319ec2705d483
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 23:00:52 2018 +0000
Disable OP longitudinal logic on vision-only cars
commit a274c9664a192a21d1035b93f2187adf224d77ad
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 22:59:30 2018 +0000
Disable OP longitudinal logic on vision-only cars
commit 31ac21e31c02ea985713b578812be50d36847079
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 22:37:24 2018 +0000
Experimental ACC - heavier deceleration and alter smoothing window
commit 96b20c14799c761bfae80f935346889c1364f12d
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 22:19:43 2018 +0000
Experimental ACC heavier decel
commit 1d227d27924b60c04aa0fe1a59be4dc4d0365907
Author: George Hotz <george@comma.ai>
Date: Fri Aug 31 10:13:40 2018 -0700
Experimental ACC distance smoothing
commit 25faa89147ade9404d0424de3993a22b47a842fa
Author: David Abrahams <40281893+AllWashedOut@users.noreply.github.com>
Date: Fri Aug 31 05:45:30 2018 -0700
Experimental ACC smoothing correction
commit bd5d72db3c70c669c1eb85a8ed10da169a9c90be
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 00:40:16 2018 +0000
Cleanup ACC
commit 4d6402e12eb2f3655013a7298d5218bf056bbbe3
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 00:36:56 2018 +0000
Better experimental ACC smoothing
commit 9b865498f3c1f19dccf70f44c432fbca4eea9217
Author: George Hotz <george@comma.ai>
Date: Thu Aug 30 16:42:15 2018 -0700
Experimental ACC smoothing
commit 549f607b5ccc0ef6e4f17c13873c83be4e4798e3
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:59:28 2018 +0000
ACC misc fixes
commit ab22418466409b96ff563ad81b005cff3ee9716a
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:54:41 2018 +0000
ACC typos
commit 74c3f53bacc0ed2118cc14c5ac14df2b26acd737
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:50:46 2018 +0000
ACC typos
commit 2a9814c8bdb7095044bf10e80bbeb08d6d09e7d6
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:44:15 2018 +0000
Fix ACC indent
commit 58a8bd911b9b7886cbc2e94419124b97660a100c
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:36:57 2018 +0000
Button for experimental ACC
commit 9a8fdd5b34b5f8d4b8e3cff974beaefbeb83a175
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 21:30:43 2018 +0000
Revert empty file "UI button for experimental ACC mode"
This reverts commit 69f73d925ffaf17e36fe61eb0e90838067f9e184.
commit dabfb949070b523135e17073619e1901e0a08a88
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 20:56:25 2018 +0000
Experimental ACC won't accel if lead is briefly lost
commit 6173d8de90d928dcf54c851a3db7f4a271afc380
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 20:41:14 2018 +0000
Experimental ACC algo pingping reduction
commit 69f73d925ffaf17e36fe61eb0e90838067f9e184
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 19:20:51 2018 +0000
UI button for experimental ACC mode
commit 6ac6ca8f104bd15dbf92d7fa00721d2b37eea962
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 19:20:26 2018 +0000
Experimental ACC mode. Not UI accessible.
commit b3654cbcc9150c5c1388d9be723e707854700dd1
Author: Andrew Frahn <emmertex@gmail.com>
Date: Mon Sep 10 08:30:36 2018 +1000
Kia Sorento and future Multi-Car Support (#346)
* hyundai WIP
* steer_driver_factor is 1
* removed unnecessary file
* removed unnecessary code
* Update carcontroller.py
bug fix
* safety tuning and fixed interface stiffness
* better lateral tuning, some fixes
* Fix set speed
* added camera state reading, autoresume from stop, cancel on accel, hud alerts
* WIP
* Updated for Kia Sorento *WIP*
* Cleanup
* clean2
* Bug Fixes
* pre-merge
* Add all the cars!
* Panda to auto-detect Camera Bus
* Move Checksum Check
* Final Sorento Tuning
* Make CAN3 for Cam default
* Update README.md
* update panda, minor aesthetic updates
* few other minor changes
* added steer not allowed alert
* bup panda version to force panda update
* fixed camera alerts
commit d2b8c4f0cb937fe12ffa65f491f93a2a44636aad
Author: rbiasini <riccardo.biasini@gmail.com>
Date: Sat Sep 8 06:19:48 2018 +0200
fixed sign in after Google change (#357)
commit 69da74686ddb4d15db79e3c6d877d3ad86d25a38
Author: David Abrahams <you@example.com>
Date: Fri Sep 7 17:36:16 2018 +0000
Remove expiermental ACC; it was not successful.
commit 50d9c446cf4abf5214e73d7d6a32b2cb926f37c9
Author: zeeexsixare <32753720+zeeexsixare@users.noreply.github.com>
Date: Thu Sep 6 23:03:10 2018 -0400
Tried native Stop and Go on Highlander ICE with no comma pedal: Works! (#353)
* Trying to make Highlander ICE stop and go
* Making acceleration slow for fuel efficiency
* Removing annoying commanded disengage beep
* Raised accel_max by 50% and commented on chime
* Testing if Highlander ICE can resume follow from 0
* Returned to 1.5 m/s2 for testing stop and go
* Prep for merging upstream
* Prep for upstream merge item #2
* Added Highlander ICE/Hybrid to Stop and Go
Also updated table of vehicles
* Rollback advertising stop and go for Highlanders
* Fix whitespace
commit 6eb1247426f9d6e136968d4ba3785f07b5b581fb
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date: Thu Sep 6 20:01:53 2018 -0700
GM: update readme, ACC is a required package (#354)
ACC implies Driver Confidence II, but not the other
way around. Openpilot requires front, long range radar
that only comes with ACC package.
commit 4f87bcf136a701698bf49699152bac820be89abc
Author: David Abrahams <you@example.com>
Date: Fri Sep 7 00:18:45 2018 +0000
ACC: More cautious value for full stops
commit 0b3dbc3904c2fa9abe5a07110fca200be43e34a1
Author: David Abrahams <you@example.com>
Date: Fri Sep 7 00:08:35 2018 +0000
ACC: Further strengthen full-stop logic
commit f04a228f316ab4e0bd54eb815ba1680e6a824188
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 19:01:04 2018 +0000
ACC: syntax fix
commit faea9a42c4d1d0a0c60a8e0df399051cf6a1af1c
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date: Thu Sep 6 11:59:05 2018 -0700
GM: go passive if detected ASCM or LKA camera (#350)
Since fingerprint is powertrain CAN only, camera still present
on object bus is not an issue.
commit b9e5a132d644168ac44d3472b4b467f7d59f78e8
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 18:32:57 2018 +0000
ACC: even more readable accel logic
commit e5202d6d7486df90fd22d8ab507c05935654613a
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 18:20:29 2018 +0000
ACC: clean up accel logic
commit 07c0442b28c554166fc16dc5202825a1e7e4163c
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 17:28:30 2018 +0000
ACC: strengthen stopped traffic check
commit 6a9e17a189f50c07dd8220c40693f1cefbc7cee5
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 16:55:06 2018 +0000
ACC syntax fix
commit 01e9e250055f9403e7ed12b80afa60405a4703f9
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 16:53:28 2018 +0000
ACC syntax fix
commit ff6603813051ee44693d74bfa28ce07f17f1b0e5
Author: David Abrahams <you@example.com>
Date: Thu Sep 6 16:51:12 2018 +0000
ACC module tweaks
commit 86813e6d37ca16185b79b68ca340484ecffac08a
Author: daehahn <daehyuk@hotmail.com>
Date: Wed Sep 5 15:29:36 2018 -0700
Correct typo for Highlander (#349)
commit d621f156ffaa1455842a79aa26c033258041719c
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 22:08:57 2018 +0000
ACC comment fix
commit 4e427854385bf4000c411e7d8642e0da8cf9e59e
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 19:14:40 2018 +0000
Prevent accel under safe range in JJ ACC
commit 3984fa02a517840e38af15a32758f0c3c3f3625b
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 19:08:31 2018 +0000
ACC stopped traffic enhancement
commit 933fdc28b86b5c975e6cb9d836312c2af9f55c09
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 18:59:34 2018 +0000
Experimental ACC: cleanup smoothing
commit b91f142a76cdea1128299e851051ef777cdacfd6
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 18:52:24 2018 +0000
ACC: Take existing accel/decel into account in JJ algorithm
commit 9b735811444bf805a4e50f4b7c71c9b2dc701c52
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 16:08:46 2018 +0000
More conservative ACC follow
commit 1f23156b9595e24021d33ba9af37f8cbc9471459
Author: David Abrahams <you@example.com>
Date: Wed Sep 5 15:51:43 2018 +0000
Add stopped traffic to JJ algo
commit 868b006cc384138d82e6d4364b247328672a700c
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 20:21:14 2018 +0000
Experimental ACC: disable smoothing
commit 157862ff9a53f1b701009ad22c4f29d6337642f1
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 20:06:40 2018 +0000
Experimental ACC: fix method signature
commit 7752a47add54a06dedd6ae812a8ce57fa86bed0b
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 20:00:59 2018 +0000
Experimental ACC: divide by zero fix
commit 51fbaac1af2935b5a3c8734cc28a2a3a6c9e6230
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 18:43:35 2018 +0000
Experimental ACC: remove distance smoothing
commit a1200ab234223c62d4f370e0beb1dd2befa79d94
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 18:20:04 2018 +0000
Experimental ACC: Weight speed observations by distance also
commit 72f7016fa20c364b17f823fba5c4e70a1c52d02b
Author: David Abrahams <you@example.com>
Date: Tue Sep 4 18:15:13 2018 +0000
Experimental ACC: correct weight function
commit 012727ef6069586642d7965f263bc58afac19778
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date: Tue Sep 4 00:21:04 2018 -0700
Change dashboard command of GM to use packer (#347)
* Change dashboard command of GM to use packer
Also, separate "follow distance" from "engaged".
* Fix dashboard setSpeed scaling
commit 9653f9d6a6b84d5d0c9ba920a44e407828700213
Author: Vasily Tarasov <vtarasov@zoneos.com>
Date: Tue Sep 4 00:16:09 2018 -0700
Fix pre-enable engagement on GM (#348)
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas
is commanded while user presses gas pedal. PID winds up,
and when PCM fault clears, car gets a "max gas" jolt.
In 2018 Volts, PCM fault doesn't time out, which means pre-enable
doesn't work at all, and car would slowly decelerate, while openpilot
thinks it's engaged.
commit 285c52eb693265a0a530543e9ca0aeb593a2a55e
Author: Vehicle Researcher <user@comma.ai>
Date: Mon Sep 3 16:43:12 2018 -0700
openpilot v0.5.3 release
commit 8f6e36f426a2b5e05a4aadfe99b1cc23f49ec9c4
Merge: f0c5ca7 75db5e8
Author: Vehicle Researcher <user@comma.ai>
Date: Mon Sep 3 16:41:18 2018 -0700
Merge opendbc subtree
commit 75db5e854e62bd1943148524f47b4ebb8d7a6e64
Author: Vehicle Researcher <user@comma.ai>
Date: Mon Sep 3 16:41:18 2018 -0700
Squashed 'opendbc/' changes from 2210752..af7fff8
af7fff8 Toyota Highlander: fixed dbc file name
3a979f5 Added Toyota Highlander Hybrid
3148fab Tesla: Add missing line break after VAL_ 69 WprSw6Posn (#109)
f70b8dc Hyundai: not sure why steer angle was unigned... seems a bug
1f40c31 Santa Fe: dealing with steer torque integer is easier for now
c081f73 Santa Fe: how come the steer angle sign was wrong
0da25ac Toyota Pedal Support (#108)
353aa54 Santa Fe: added lane icon color to dbc
4f76e9b Santa Fe: this signal seems 2 bits long
01cffdc Santa Fe: for now unitless torque request
390b926 added gear to dbc for Hyundai
0a04a43 Hyundai Santa Fe: first dbc commit
git-subtree-dir: opendbc
git-subtree-split: af7fff8f7f154457b88fb2e0fff789889bc9af70
commit f0c5ca7227e1724b430b2501be442dd44eb51aeb
Merge: 8970cc8 c4bba32
Author: Vehicle Researcher <user@comma.ai>
Date: Mon Sep 3 16:41:16 2018 -0700
Merge panda subtree
commit c4bba3234721f0e7d546b71d9ba5f32996e8463e
Author: Vehicle Researcher <user@comma.ai>
Date: Mon Sep 3 16:41:16 2018 -0700
Squashed 'panda/' changes from b058c14..f2292e4
f2292e4 Hyundai: added safety check for button spam
1a8c4c4 Hyundai safety: fwd option
5398abf Hyundai safety: added tests for cruise enable/disable too
a91d7ef added hyundai regression test
487fcae Safety hyundai: fixed RT check
04270b8 Safety Hyundai: bug fixes
d0c28b7 Hyndai safety: tuned
ad1ba69 Hyundai safety: fixed wrong param
8a1dcbe Hyundai safety: added Santa Fe safety: need to be tested. Removed some unnecessary funcitons
4e9d08a Hyundai safety: controls_allowed ==1 by default for now
f42d092 Hyundai all output for now
7927cab compiling the use of bitbang_gmlan only for panda
4fe2dcd build pedal image in CI
3d67294 keep pedal obj folder
git-subtree-dir: panda
git-subtree-split: f2292e420bd856b8cef6633af46e2641f401e84c
commit 8970cc8d7024e6a4c39a2c89b8cd6aa3fadcd54b
Author: tentious <nbumgart@gmail.com>
Date: Sun Sep 2 22:06:19 2018 -0500
Honda Odyssey 2018/2019 EX-L PID Tuning (#343)
* Honda Odyssey 2019 EX-L PID Tuning.
* Update interface.py - Increased Kp for Odyssey
Increases response from 0.4, but oscillation still occurs in very sharp curves.
commit 54f3c2b373d2dd6ecca485267b280697d7321406
Author: Ted Slesinski <ted@slesinski.org>
Date: Fri Aug 31 22:57:11 2018 -0400
Some code refactoring to Honda (#335)
* Move vehicle state values (that get sent to radar) into values.py file, its a better place for it :)
* idx with offset should only be applied to 0x300
* Adds new honda pilot to vehicle state msg array
commit b9f2dac9c202904ceeb7ce53b4c8330e107e4ac6
Author: George Hotz <george@comma.ai>
Date: Fri Aug 31 18:40:52 2018 -0700
Experimental ACC: fix unit conversion
commit f586e4ecf73475de77ecb310f1c295f55bd58b58
Author: David Abrahams <you@example.com>
Date: Sat Sep 1 00:01:42 2018 +0000
Experimental ACC: don't smooth distance
commit 184bf60e1fd254faf31e1b7fa3124780e60e68bd
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 23:43:40 2018 +0000
Experimental ACC: isolate smoothing logic into a class
commit 719d984d8e5320315aab7362fe3319ec2705d483
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 23:00:52 2018 +0000
Disable OP longitudinal logic on vision-only cars
commit a274c9664a192a21d1035b93f2187adf224d77ad
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 22:59:30 2018 +0000
Disable OP longitudinal logic on vision-only cars
commit 31ac21e31c02ea985713b578812be50d36847079
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 22:37:24 2018 +0000
Experimental ACC - heavier deceleration and alter smoothing window
commit 96b20c14799c761bfae80f935346889c1364f12d
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 22:19:43 2018 +0000
Experimental ACC heavier decel
commit 1d227d27924b60c04aa0fe1a59be4dc4d0365907
Author: George Hotz <george@comma.ai>
Date: Fri Aug 31 10:13:40 2018 -0700
Experimental ACC distance smoothing
commit 25faa89147ade9404d0424de3993a22b47a842fa
Author: David Abrahams <40281893+AllWashedOut@users.noreply.github.com>
Date: Fri Aug 31 05:45:30 2018 -0700
Experimental ACC smoothing correction
commit bd5d72db3c70c669c1eb85a8ed10da169a9c90be
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 00:40:16 2018 +0000
Cleanup ACC
commit 4d6402e12eb2f3655013a7298d5218bf056bbbe3
Author: David Abrahams <you@example.com>
Date: Fri Aug 31 00:36:56 2018 +0000
Better experimental ACC smoothing
commit 9b865498f3c1f19dccf70f44c432fbca4eea9217
Author: George Hotz <george@comma.ai>
Date: Thu Aug 30 16:42:15 2018 -0700
Experimental ACC smoothing
commit 549f607b5ccc0ef6e4f17c13873c83be4e4798e3
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:59:28 2018 +0000
ACC misc fixes
commit ab22418466409b96ff563ad81b005cff3ee9716a
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:54:41 2018 +0000
ACC typos
commit 74c3f53bacc0ed2118cc14c5ac14df2b26acd737
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:50:46 2018 +0000
ACC typos
commit 2a9814c8bdb7095044bf10e80bbeb08d6d09e7d6
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:44:15 2018 +0000
Fix ACC indent
commit 58a8bd911b9b7886cbc2e94419124b97660a100c
Author: EC2 Default User <ec2-user@ip-172-31-66-215.ec2.internal>
Date: Thu Aug 30 21:36:57 2018 +0000
Button for experimental ACC
commit 9a8fdd5b34b5f8d4b8e3cff974beaefbeb83a175
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 21:30:43 2018 +0000
Revert empty file "UI button for experimental ACC mode"
This reverts commit 69f73d925ffaf17e36fe61eb0e90838067f9e184.
commit dabfb949070b523135e17073619e1901e0a08a88
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 20:56:25 2018 +0000
Experimental ACC won't accel if lead is briefly lost
commit 6173d8de90d928dcf54c851a3db7f4a271afc380
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 20:41:14 2018 +0000
Experimental ACC algo pingping reduction
commit 69f73d925ffaf17e36fe61eb0e90838067f9e184
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 19:20:51 2018 +0000
UI button for experimental ACC mode
commit 6ac6ca8f104bd15dbf92d7fa00721d2b37eea962
Author: David Abrahams <you@example.com>
Date: Thu Aug 30 19:20:26 2018 +0000
Experimental ACC mode. Not UI accessible.
commit 2c4e1fd4fa786f580cb91dd255ce2b8aa5905789
Author: Riccardo <riccardo.biasini@gmail.com>
Date: Tue Aug 28 14:25:00 2018 -0700
Added Pilot 2019 as supported car to README
klaus385
pushed a commit
to klaus385/openpilot
that referenced
this pull request
Dec 31, 2018
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas is commanded while user presses gas pedal. PID winds up, and when PCM fault clears, car gets a "max gas" jolt. In 2018 Volts, PCM fault doesn't time out, which means pre-enable doesn't work at all, and car would slowly decelerate, while openpilot thinks it's engaged.
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas is commanded while user presses gas pedal. PID winds up, and when PCM fault clears, car gets a "max gas" jolt. In 2018 Volts, PCM fault doesn't time out, which means pre-enable doesn't work at all, and car would slowly decelerate, while openpilot thinks it's engaged.
mlocoteta
pushed a commit
to mlocoteta/openpilot
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2017 Volts, PCM fault occurs for a few seconds if ACC gas
is commanded while user presses gas pedal. PID winds up,
and when PCM fault clears, car gets a "max gas" jolt.
In 2018 Volts, PCM fault doesn't time out, which means pre-enable
doesn't work at all, and car would slowly decelerate, while openpilot
thinks it's engaged.