boardd: keep defined safety models in sync with panda repo #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a noop for most users, but for those of us working on new car ports where we have our own additional defines, having those defines out of sync creates merge conflicts in one place (good so we can fix it) but not the other ( not good becasue they will go unnoticed). I learned this the hardway!. Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
klaus385
pushed a commit
to klaus385/openpilot
that referenced
this pull request
Dec 31, 2018
This is a noop for most users, but for those of us working on new car ports where we have our own additional defines, having those defines out of sync creates merge conflicts in one place (good so we can fix it) but not the other ( not good becasue they will go unnoticed). I learned this the hardway!. Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
icmma
pushed a commit
to priuscom/openpilot
that referenced
this pull request
Jul 17, 2019
5 ways ahead and fix for lagging zmq
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
This is a noop for most users, but for those of us working on new car ports where we have our own additional defines, having those defines out of sync creates merge conflicts in one place (good so we can fix it) but not the other ( not good becasue they will go unnoticed). I learned this the hardway!. Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a noop for most users, but for those of us working on new
car ports where we have our own additional defines, having
those defines out of sync creates merge conflicts in one place
(good so we can fix it) but not the other ( not good becasue
they will go unnoticed). I learned this the hardway!.
Signed-off-by: Jafar Al-Gharaibeh to.jafar@gmail.com