-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow uploader.py to compress rlog without upload permission #471
Conversation
…d without any upload permission.
…el-always-compress
…n/openpilot into devel-always-compress
…el-always-compress
Can I suggest you also add this. 127 # try to upload compressed log files first |
…ss uncompressed rlog (suggested by ku7)
…en process uncompressed rlog (suggested by ku7)" This reverts commit 98d7c45.
@emmertex I have changed it back, if we return rlog.bzip2 files first that means none of the rlog will be compressed until all the rlog.bzip2 are uploaded. |
I seen that, after I tested a long drive. |
looks like a good change, thanks. Is it good to go? @emmertex or anybody else had a chance to test it? |
I need to retest, I'll review in a day or 2
…On Mon., 24 Dec. 2018, 6:15 pm rbiasini, ***@***.***> wrote:
looks like a good change, thanks. Is it good to go? @emmertex
<https://github.com/emmertex> or anybody else had a chance to test it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#471 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE2DlUUVmeg7-xEqZrm2nR5kBQUZMRW3ks5u8H77gaJpZM4ZXiHz>
.
|
So sorry I forgot about this.. |
This (exactly as per this PR) has been integrated in my fork since start of the year snippet of output of ls -R showing it working properly `./2019-01-23--23-29-47--0: ./2019-01-24--09-12-12--0: ./2019-01-24--09-19-27--0: ./2019-01-24--09-57-43--0: ./2019-01-24--09-57-43--1: ./2019-01-24--09-57-43--10: ./2019-01-24--09-57-43--2: ./2019-01-24--09-57-43--3: ./2019-01-24--09-57-43--4: ./2019-01-24--09-57-43--5: |
Allow uploader.py to compress rlog without upload permission commaai#471
…el-always-compress
…el-always-compress
…el-always-compress
* Add "Accept-Encoding: gzip" header to mapd.py to reduce data consumption (commaai#525) * Allow uploader.py to compress rlog without upload permission (commaai#471) * Always Compress - Make sure uploader to bzip2 rlog once it's completed without any upload permission. * Squashed 'panda/' changes from 9ee6285..39c1e39 39c1e39 Cadillac: added brake msg forwarding aaa1b14 bump VERSION e0dd558 Fixed undefined reference error when "make recover" in EON c91f038 Toyota pedal support (commaai#159) de1ba06 Build optimizer: back to Os now that 'make --recover' is fixed fd23383 add -lgcc flag to fix "undefined reference to __aeabi_llsr" (commaai#156) 1cc74e2 Reverted code optimizer option to O2 after 'make recover' broke 1218d09 Cadillac ascm proxy (commaai#155) 064446f Panda: bumped version 93266a9 Hyundai: allow the same max steer torque as stock d275fa8 Subaru: Forwarding (commaai#152) git-subtree-dir: panda git-subtree-split: 39c1e39 * Squashed 'opendbc/' changes from b632acf..45c3285 45c3285 Added support to Toyota pedal cfb7070 Revert "Added pedal support for Toyota" ca607f4 Added pedal support for Toyota 22efd56 Honda: for simplicity all cars now have BRAKE_HOLD signal f969de0 Honda Nidec: VSA_STATUS msg is teh same for all 85b0df7 chrysler L gear (commaai#139) b9618da Update Gear Packet with Eco and Sport button (commaai#135) 5259345 Update DBC for Hyundai Kona Support (commaai#138) 608caba Create subaru_outback_2015_eyesight.dbc (commaai#137) git-subtree-dir: opendbc git-subtree-split: 45c3285 * Squashed 'pyextra/' changes from 8cc1594..0d19c13 0d19c13 Revert adding reverse_geocoder 4a22fac Fix reverse_geocoder folder 35308c5 Add reverse_geocoder git-subtree-dir: pyextra git-subtree-split: 0d19c13e6e4e5fa82a470374146a86dc5d5afa35 * openpilot v0.5.9 release * remove unneeded msg variable minimize diff with upstream * change error back to perm * allow it to instantly ramp down to 0 * try new panda safety code * minor panda cleanup
Add speed hump with bump attributes
…#471) * Always Compress - Make sure uploader to bzip2 rlog once it's completed without any upload permission.
rlog does not compress to rlog.bzip2 until upload is allowed, which means users like me who only upload logs with WIFI will waste quite a bit of space.
OP generates a folder each minute with at least 2 files in it:
![rlog](https://user-images.githubusercontent.com/16603033/50191689-a7f11980-037a-11e9-95d9-359de3634142.png)
after compression, rlog size is reduced to 7mb (vs 25.5mb)
1 hr drive will save roughly around 1G of space.