Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly more compatible Highlander fingerprints #635

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@ErichMoraga
Copy link
Contributor

commented May 10, 2019

As discussed with Daehyuk, Arne, and HskrOP on Discord in #help...
https://discordapp.com/channels/469524606043160576/524592892627517450/576451670268051480

PR change is the same as seen in @arne182's fork...
https://github.com/arne182/openpilot/blob/release2/selfdrive/car/toyota/values.py

Additional modification(s) may be required later, but this is apparently a step in the right direction.

Slightly more compatible Highlander fingerprints
As discussed with Daehyuk, Arne, and HskrOP on Discord in #help...
https://discordapp.com/channels/469524606043160576/524592892627517450/576451670268051480

Additional modification(s) may be required later, but this is apparently a step in the right direction.
@arne182

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

I thought I clearly said that comma wants to keep trims seperate.

@ErichMoraga

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

...and I agreed with that, yet the group seemed to agree there's a compatibility issue with the current values. Feel free to propose change(s).

@rbiasini

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

If you guys can give us the dongleID of users who had fingerprint issue, we'll handle the rest. How is that?
I'm really tempted to merge this PR and #631, but then it will be hard to keep adding new models in the future.

@ErichMoraga

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

Sent IDs to you via Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.