Slightly more compatible Highlander fingerprints #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with Daehyuk, Arne, and HskrOP on Discord in #help... https://discordapp.com/channels/469524606043160576/524592892627517450/576451670268051480 Additional modification(s) may be required later, but this is apparently a step in the right direction.
|
I thought I clearly said that comma wants to keep trims seperate. |
|
...and I agreed with that, yet the group seemed to agree there's a compatibility issue with the current values. Feel free to propose change(s). |
|
If you guys can give us the dongleID of users who had fingerprint issue, we'll handle the rest. How is that? |
|
Sent IDs to you via Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Daehyuk, Arne, and HskrOP on Discord in #help...
https://discordapp.com/channels/469524606043160576/524592892627517450/576451670268051480
PR change is the same as seen in @arne182's fork...
https://github.com/arne182/openpilot/blob/release2/selfdrive/car/toyota/values.py
Additional modification(s) may be required later, but this is apparently a step in the right direction.