Show loading progress #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice idea |
|
Not sure why the Makefile is not open source. Here it is: https://gist.github.com/pd0wm/6c4c716ea14b5afeb0ec171f8c9e25c0 Does this reset the spinner position every time we restart it? Isn't it cleaner to have spinner (optionally) listen to a socket where we can send it new text while we keep it running? |
|
Awesome, thanks. This is a little hacked together so it does reset (opens a new pipe every update). Not ideal in any sense. |
|
It might not need a zmq socket. We can also keep sending it stuff over stdin. The spinner can show the new text every time we send a newline. |
|
closing for now while I work out some finer details. Writing to stdin works well now. |
Closed
debugged-tech
pushed a commit
to debugged-tech/DebuggedPilot
that referenced
this pull request
Jan 12, 2021
* toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py * tune dg * add AVALON_2021 in dp080 * sync (#93) * Update dp_common.py * Update dp_common.py * RSA, Distance button and briskspirit longcontrol (commaai#762) * toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> * corolla_TSS2: tune (commaai#760) * Update interface.py updated corollatss2 tuning * Update toyota_nodsu_pt_generated.dbc * Update toyota_nodsu_hybrid_pt_generated.dbc * Update op_params.py * Create toyota_nodsu_pt_generated_corolla_tss2.dbc * Create toyota_nodsu_pt_generated_corollah_tss2.dbc * revert to stock. * revert to stock * point corolla and corollah to its own separate dbc. * add corolla and corollah dbc to release. * Update interface.py Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com> Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> * added dbc to release and test route. * cant use the route since comma doesnt got it. * i cant spell * add PIControllerk_f * Add kfV and kfBP to PIDTuning * update the car interfaces for bfv and kfbp tunning. * Add scanner for Cython dependencies * cleanup unused android libs in phonelibs (commaai#19702) Co-authored-by: Comma Device <device@comma.ai> * syntax * E502 flake8 fix * fix * make it list. * ugh list * kfV * forgot vw * update ford * Shanes PIDController: orvershooting fix * action fix. * restore crash logging trackign of fork and branch. * add pirus to nodsu * fix * fix for crash * my bad. * revert. * working. Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Comma Device <device@comma.ai>
rav4kumar
added a commit
to rav4kumar/openpilot
that referenced
this pull request
Jan 13, 2021
* support for kfv and kfbp and overshooting fix (commaai#768) * toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py * tune dg * add AVALON_2021 in dp080 * sync (#93) * Update dp_common.py * Update dp_common.py * RSA, Distance button and briskspirit longcontrol (commaai#762) * toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> * corolla_TSS2: tune (commaai#760) * Update interface.py updated corollatss2 tuning * Update toyota_nodsu_pt_generated.dbc * Update toyota_nodsu_hybrid_pt_generated.dbc * Update op_params.py * Create toyota_nodsu_pt_generated_corolla_tss2.dbc * Create toyota_nodsu_pt_generated_corollah_tss2.dbc * revert to stock. * revert to stock * point corolla and corollah to its own separate dbc. * add corolla and corollah dbc to release. * Update interface.py Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com> Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> * added dbc to release and test route. * cant use the route since comma doesnt got it. * i cant spell * add PIControllerk_f * Add kfV and kfBP to PIDTuning * update the car interfaces for bfv and kfbp tunning. * Add scanner for Cython dependencies * cleanup unused android libs in phonelibs (commaai#19702) Co-authored-by: Comma Device <device@comma.ai> * syntax * E502 flake8 fix * fix * make it list. * ugh list * kfV * forgot vw * update ford * Shanes PIDController: orvershooting fix * action fix. * restore crash logging trackign of fork and branch. * add pirus to nodsu * fix * fix for crash * my bad. * revert. * working. Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Comma Device <device@comma.ai> * better logging for fingerprint missing * Function log_fingerprinted not needed Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Comma Device <device@comma.ai>
rav4kumar
added a commit
to rav4kumar/openpilot
that referenced
this pull request
Jan 14, 2021
* support for kfv and kfbp and overshooting fix (commaai#768) * toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py * tune dg * add AVALON_2021 in dp080 * sync (#93) * Update dp_common.py * Update dp_common.py * RSA, Distance button and briskspirit longcontrol (commaai#762) * toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> * corolla_TSS2: tune (commaai#760) * Update interface.py updated corollatss2 tuning * Update toyota_nodsu_pt_generated.dbc * Update toyota_nodsu_hybrid_pt_generated.dbc * Update op_params.py * Create toyota_nodsu_pt_generated_corolla_tss2.dbc * Create toyota_nodsu_pt_generated_corollah_tss2.dbc * revert to stock. * revert to stock * point corolla and corollah to its own separate dbc. * add corolla and corollah dbc to release. * Update interface.py Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com> Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> * added dbc to release and test route. * cant use the route since comma doesnt got it. * i cant spell * add PIControllerk_f * Add kfV and kfBP to PIDTuning * update the car interfaces for bfv and kfbp tunning. * Add scanner for Cython dependencies * cleanup unused android libs in phonelibs (commaai#19702) Co-authored-by: Comma Device <device@comma.ai> * syntax * E502 flake8 fix * fix * make it list. * ugh list * kfV * forgot vw * update ford * Shanes PIDController: orvershooting fix * action fix. * restore crash logging trackign of fork and branch. * add pirus to nodsu * fix * fix for crash * my bad. * revert. * working. Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Comma Device <device@comma.ai> * better logging for fingerprint missing * Function log_fingerprinted not needed * F821 and F722 * Update values.py 21 Genesis G70 optimization Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> Co-authored-by: Willem Melching <willem.melching@gmail.com> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> Co-authored-by: Comma Device <device@comma.ai> Co-authored-by: sebastian4k <69202924+sebastian4k@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply displays, for example, "loading openpilot: 3/21 plannerd"
I feel like we used to have something like this years ago.. could be dreaming
Also, if this implementation is ok, I'd be happy to replace this with a gui loading bar if I had a makefile for spinner