Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Classic Tesla Model S #121

Closed
wants to merge 1 commit into from
Closed

Support for Classic Tesla Model S #121

wants to merge 1 commit into from

Conversation

zax123
Copy link
Contributor

@zax123 zax123 commented Jun 8, 2018

Contains RX and TX safety hooks for Classic (non-AP) Tesla Model S

Also contains forwarding code to bypass the EPAS kill message sent from the gateway.

Requires the harness as designed by @kalud and @zax123 and the Tesla giraffe.

@rbiasini
Copy link
Contributor

@zax123 let me know if this is up to date. If yes, then it can probably be merged as is, even though the safety code will need some changes before the Tesla support can be upstreamed to openpilot.

Some questions/comments:

  • I don't see a steering angle rate limit. Is it enforced by the EPS? If yes, is it speed dependent? Is it well tuned?
  • Max angle should be function of speed. 20 deg seems quite low at low speed and too high at high speeds.

@jeankalud
Copy link

We want and will add those safety in Panda code.

  • EPS internal firmware already limits angle rate quite and its speed dependant
  • Absolute max angle is limited in EON's code, its not fixed 20 degreee but a function of speed:

https://github.com/jeankalud/openpilot/blob/tesla/selfdrive/car/tesla/carcontroller.py#L119-L129

But now that we have some more people helping us, the progress is going well and we will support the code without issues.

int tesla_speed = 0;
int current_car_time = -1;
int time_at_last_stalk_pull = -1;
int eac_status = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make all those shared variables starting with tesla_?

@zax123
Copy link
Contributor Author

zax123 commented Jul 18, 2018

Hi @rbiasini,

Absolutely, I will rename those shared variables. We are working on solidifying all the safety parameters on Thursday evening and will send new cleaned-up code on Friday.

Thanks for looking into this!

@rbiasini
Copy link
Contributor

rbiasini commented Nov 2, 2018

superseded by #132

@rbiasini rbiasini closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants