-
Notifications
You must be signed in to change notification settings - Fork 477
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 pulls in many NuGet dependencies #227
Comments
Hi, yeah it does install a few 'core' dependencies even on the full framework. It's unintentional and something that needs to be fixed. In theory you should be able to delete those dependencies from your project manually and it should still work since we aren't using any new APIs in Core. Either way, it definitely works on 4.6.1 without issue (the Nuget is dual-targeted to Core and the Full Framework) |
Hi nemec, Thanks, that helps me put it in perspective. For your FYI, for users like me, it would be much better to have separate Core/Framework packages as we do not, in production, reference NuGet web sites. So, in this case I had to download and install all of the Core packages into our local NuGet site. I also have to justify the extra NuGet references in code reviews. So it was/is quite a burden that I have not through yet. I may need to revert if other reject the code as it adds Core packages. Thx Rob |
@RobSmyth hey rob, I dont think you need to include Core dependencies (better to use the term "netstandard" now) in your installer since I'm assuming you're project targets a desktop framework, ie, netframework 4.6.1+ then you should be okay. That also means you're not invoking your program via Btw, we're not the only package that includes both netstandard/netframework dependencies, however depending on your nuget hosting situation, you may have had to download the netstandard dependencies just to make the package valid on your own nuget server. Based on the current direction of nuget and netcore, I think you'll find this to be the case for more libraries going forward. Also, certain netframework versions support particular netstandard versions, check the netstandard support matrix on msdn for more info: https://github.com/dotnet/standard/blob/master/docs/versions.md Our design is intended to be the lowest common denominator that we could use, which initially was netstandard1.5 which is also supported by netframework 4.6.1+ |
@RobSmyth As can bee seen on the picture the NuGet package has properly specified multiple dependencies. CommandLineParser includes only dependencies for NET Standard and those are invalid prerelease. Best regards |
Are you saying I do not need to deploy any other DLL files in my installer? At the moment I include all of them. |
@okvalsralos @nemec @ericnewton76 .nuspec file is incorrect.
|
@ericnewton76 @nemec I tried fixing .nuspec, but I'm confused about what's going on during build. So, I ran What you should do instead is switch to new .csproj format with muti-targeting, set You should also consider getting rid of Paket, which is pretty much redundant with Core MSBuild. You include files through it (3 files copied from gsscoder's GitHub), which NuGet doesn't support, but it's a very questionable practice, you should just copy the files into the repository. (Related: #222) |
I think this was on track to being fixed, but then something happened to the .nuspec between https://github.com/commandlineparser/commandline/tree/5c5fc3322e9255f30a81c1b7163af3f8bd907e5f and https://github.com/commandlineparser/commandline/tree/6cc3cbd2f690880426cf66634482fdb4ed5509c9. |
This problem is resolved in the release 2.5.0 which support net40,net45,net461 and netstandard2.0.
|
Hi,
On upgrade from 1.9 to the latest ver 2 I found that there were many NuGet dependencies. Question/issues:
Thanks
The text was updated successfully, but these errors were encountered: