-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AutoHelp and AutoVersion properties to control adding of implicit 'help' and 'version' options/verbs #256
Added AutoHelp and AutoVersion properties to control adding of implicit 'help' and 'version' options/verbs #256
Conversation
…it 'help' and 'version' options/verbs.
I think this solves the issues nicely. Can you add a few tests to help us prevent regressions? I think the following should cover things, but if you think of any other scenarios feel free to include them:
|
@nemec Added tests. |
@nemec Can it be merge time? |
@Athari |
@moh-hassan
What others have commented on the #461 is correct: I'd expect Anyway, what's the current status? Wasn't #461 closed? P.S. Frankly, I consider this library a lost cause, mostly because the original developer went crazy with the pseudo-functional style and made a mess of both the public API (tons of callbacks) and the implementation ("maybe" and other reinvented wheels with very poor implementations), while completely ignoring good old code smells like methods with tons of arguments, and I doubt anybody is going to spend time refactoring the whole codebase and making massive backwards compatbility breaking changes to public API yet again, even if it's allowed by the current maintainers. |
Just giving a heads up. It is possible to override --help and --version now if you set AutoHelp and AutoVersion to false in the parser config. |
Covers #87 and #200.