-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-notifications): add OverlappingPriceValidity and OverlappingStandalonePriceValidity error codes #3517
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a27d519 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
OverlappingStandalonePriceValidity
err…a7ceacc
to
868013f
Compare
868013f
to
c319ff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Thanks Rafa!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Please include a changeset
c319ff6
to
3fa9be0
Compare
3fa9be0
to
a27d519
Compare
Blocked until https://github.com/commercetools/sphere-backend/pull/13906 gets merged |
The BE PR has been merged and deployed! |
…ngStandalonePriceValidity error codes (#3517) * fix: add missing message for `OverlappingStandalonePriceValidity` error code * test: add cases for price related messages * feat: add message for `OverlappingPriceValidity` error code * fix: add changeset
…ngStandalonePriceValidity error codes (#3517) * fix: add missing message for `OverlappingStandalonePriceValidity` error code * test: add cases for price related messages * feat: add message for `OverlappingPriceValidity` error code * fix: add changeset
Summary
This PR adds two new error codes: OverlappingPriceValidity and OverlappingStandalonePriceValidity that are present in priceless API
Description