Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-notifications): add OverlappingPriceValidity and OverlappingStandalonePriceValidity error codes #3517

Merged
merged 4 commits into from
May 13, 2024

Conversation

ragafus
Copy link
Contributor

@ragafus ragafus commented May 8, 2024

Summary

This PR adds two new error codes: OverlappingPriceValidity and OverlappingStandalonePriceValidity that are present in priceless API

Description

@ragafus ragafus self-assigned this May 8, 2024
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 10:26am

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: a27d519

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@commercetools-frontend/react-notifications Minor
@commercetools-frontend/i18n Minor
@commercetools-frontend/application-shell Minor
@commercetools-local/visual-testing-app Minor
@commercetools-frontend/application-components Minor
@commercetools-applications/merchant-center-template-starter-typescript Minor
@commercetools-applications/merchant-center-template-starter Minor
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Minor
@commercetools-applications/merchant-center-custom-view-template-starter Minor
@commercetools-local/playground Minor
@commercetools-website/components-playground Minor
@commercetools-frontend/cypress Minor
@commercetools-frontend/codemod Minor
@commercetools-frontend/mc-scripts Minor
@commercetools-backend/eslint-config-node Minor
@commercetools-backend/express Minor
@commercetools-backend/loggers Minor
@commercetools-frontend/actions-global Minor
@commercetools-frontend/application-config Minor
@commercetools-frontend/application-shell-connectors Minor
@commercetools-frontend/assets Minor
@commercetools-frontend/babel-preset-mc-app Minor
@commercetools-frontend/browser-history Minor
@commercetools-frontend/constants Minor
@commercetools-frontend/create-mc-app Minor
@commercetools-frontend/eslint-config-mc-app Minor
@commercetools-frontend/jest-preset-mc-app Minor
@commercetools-frontend/jest-stylelint-runner Minor
@commercetools-frontend/l10n Minor
@commercetools-frontend/mc-dev-authentication Minor
@commercetools-frontend/mc-html-template Minor
@commercetools-frontend/notifications Minor
@commercetools-frontend/permissions Minor
@commercetools-frontend/sdk Minor
@commercetools-frontend/sentry Minor
@commercetools-frontend/url-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ragafus ragafus changed the title fix: add missing message for OverlappingStandalonePriceValidity err… feat(react-notifications): add OverlappingStandalonePriceValidity error code May 8, 2024
@ragafus ragafus force-pushed the PRC-2946-embedded-price-wrong-message branch from a7ceacc to 868013f Compare May 9, 2024 09:10
@ragafus ragafus changed the title feat(react-notifications): add OverlappingStandalonePriceValidity error code feat(react-notifications): add OverlappingPriceValidity and OverlappingStandalonePriceValidity error codes May 9, 2024
@ragafus ragafus force-pushed the PRC-2946-embedded-price-wrong-message branch from 868013f to c319ff6 Compare May 9, 2024 09:16
@ragafus ragafus requested a review from a team May 9, 2024 10:05
@ragafus ragafus marked this pull request as ready for review May 9, 2024 10:05
@ragafus ragafus requested a review from a team as a code owner May 9, 2024 10:05
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Thanks Rafa!

Copy link
Contributor

@kark kark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please include a changeset

@ragafus ragafus force-pushed the PRC-2946-embedded-price-wrong-message branch from c319ff6 to 3fa9be0 Compare May 9, 2024 10:18
@ragafus
Copy link
Contributor Author

ragafus commented May 10, 2024

Blocked until https://github.com/commercetools/sphere-backend/pull/13906 gets merged

@ragafus ragafus merged commit ec2410a into main May 13, 2024
18 checks passed
@ragafus ragafus deleted the PRC-2946-embedded-price-wrong-message branch May 13, 2024 09:34
@ct-changesets ct-changesets bot mentioned this pull request May 13, 2024
@tomski-ct
Copy link

tomski-ct commented May 13, 2024

The BE PR has been merged and deployed!
🥳

obulaworld pushed a commit that referenced this pull request May 13, 2024
…ngStandalonePriceValidity error codes (#3517)

* fix: add missing message for `OverlappingStandalonePriceValidity` error code

* test: add cases for price related messages

* feat: add message for `OverlappingPriceValidity` error code

* fix: add changeset
ddouglasz pushed a commit that referenced this pull request May 22, 2024
…ngStandalonePriceValidity error codes (#3517)

* fix: add missing message for `OverlappingStandalonePriceValidity` error code

* test: add cases for price related messages

* feat: add message for `OverlappingPriceValidity` error code

* fix: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants