Fix Ambiguous module name Distribution.PackageDescription

[mpilgrem]

Using Stack 2.9.1 to build a package with a dependency on Cabal and process and:

resolver: lts-19.25 # GHC 9.0.2 (comes with Cabal-3.4.1.0)
extra-deps:
- Cabal-3.8.1.0
- Cabal-syntax-3.8.1.0
- process-1.6.15.0

yields error:

process                      > configure
process                      > [1 of 2] Compiling Main             ( C:\Users\mikep\AppData\Local\Temp\stack-d0efe7ccadb373e9\process-1.6.15.0\Setup.hs, C:\Users\mikep\AppData\Local\Temp\stack-d0efe7ccadb373e9\process-1.6.15.0\.stack-work\dist\d53b6a14\setup\Main.o )
process                      > [2 of 2] Compiling StackSetupShim   ( C:\sr\setup-exe-src\setup-shim-Z6RU0evB.hs, C:\Users\mikep\AppData\Local\Temp\stack-d0efe7ccadb373e9\process-1.6.15.0\.stack-work\dist\d53b6a14\setup\StackSetupShim.o )
process                      >
process                      > C:\sr\setup-exe-src\setup-shim-Z6RU0evB.hs:3:1: error:
process                      >     Ambiguous module name ‘Distribution.PackageDescription’:
process                      >       it was found in multiple packages:
process                      >       Cabal-3.4.1.0 Cabal-syntax-3.8.1.0
process                      >   |
process                      > 3 | import Distribution.PackageDescription (PackageDescription, emptyHookedBuildInfo)
process                      >   |

This is because StackSetupShim is compiled with (a) the version of Cabal that comes with GHC 9.0.2 and (b) the package database that includes Cabal-syntax-3.8.1.0, and both export modules named Distribution.PackageDescription.

This pull request fixes that problem by specifying that the import of Distribution.PackageDescription is to come from the Cabal package.

• Any changes that could be relevant to users have been recorded in ChangeLog.md.
• The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests! Tested by building and using Stack.

[ulysses4ever]

For the record, another way to work around it is described here: https://hackage.haskell.org/package/Cabal-syntax-3.6.0.0

[mpilgrem]

Hello @ulysses4ever. Did you have in mind the Cabal flag Cabal-syntax? As Stack compiles StackSetupShim directly with GHC (see Stack.Build.Execute.getSetupExe and the line withWorkingDir (toFilePath tmpdir) $ proc (toFilePath compilerPath) args (\pc0 -> do) I could not work out how Cabal flags would help.

[ulysses4ever]

Hey there! Indeed, I didn't account for the way Stack works at all. Btw, very clever solution with the package imports!

Apologies for the noise and all the best.