Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6377 Drop support of Cabal < 2.2 #6483

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Fix #6377 Drop support of Cabal < 2.2 #6483

merged 2 commits into from
Feb 13, 2024

Conversation

mpilgrem
Copy link
Member

  • Any changes that could be relevant to users have been recorded in ChangeLog.md.
  • The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests! Relying on CI.

@mpilgrem
Copy link
Member Author

@theobat, I think this implements what we have discussed. However, before I put it through, may I double-check that you still think that dropping support for Cabal < 2.2 will make it easier for you to make the other changes that you have in mind?

@theobat
Copy link
Contributor

theobat commented Feb 13, 2024

@mpilgrem, it's not that it'll make the planned changes easier, it's that we can't have component based builds for cabal less than 2.2, because the interface* simply didn't exist.
Component based builds are a requirement for several things such as backpack and more parallelism at the action level (parallel per components versus parallel per packages).

And given this requirement, it also makes sense to remove the complexities of these cabal versions.

* Quoting the cabal doc:

In Cabal 2.0, support for a single positional argument was added to runhaskell Setup.hs configure This makes Cabal configure the specific component to be configured. Specified names can be qualified with lib: or exe: in case just a name is ambiguous (as would be the case for a package named p which has a library and an executable named p.)

@mpilgrem mpilgrem merged commit 250d8c0 into master Feb 13, 2024
14 checks passed
@mpilgrem mpilgrem deleted the fix6377 branch February 13, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants