651 target parse overhaul #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reassigning to @borsboom. I'm happy with the current state of this, so it's up to you when this should be merged to master. |
This was referenced Aug 11, 2015
|
Discussed with @borsboom, we're moving ahead with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite ready for merge to master. I want to review the diff and do some cleanup, and then it's up to @borsboom on timing. I originally said this should be merged after the upcoming release, but this is already looking pretty stable, so I'm not necessarily opposed to including it now.
Pinging @chrisdone for review
Merging this to master resolves #651