New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aeson 0.10 #845
Comments
new revisions of binary-orphans and binary-tagged published |
Also, be aware of really breaking change haskell/aeson#287 |
twitter-feed is updated in Hackage now. |
Mandrill 0.4.1.0 is updated & on Hackage now, fixed by: adinapoli/mandrill#22 |
json-autotype is fixed too. On Sunday, September 20, 2015, Alfredo Di Napoli notifications@github.com
Pozdrawiam |
Is there actually any point in everyone reporting here that a fix is uploaded? I would presume that the stackage admins would see what’s fixed and what not based on their tool, and use that to check it. At least until there are only two or three packages left which everyone is waiting on, in which case a “I’m finally done message” might be useful. |
smoothie fixed. |
"hasql-postgres" is fixed, but I would love to see the maintainers' input on @nomeata's comment. |
When it's just a few packages: telling us to try again is very helpful. With lots of packages: everyone needs to do the mental checklist of "did everyone else already fix this?" In which case: it's less useful. The curator team will regularly check on open issues and see if they're still relevant, so that seems like the right way to address these big issues. How's this for a policy: if there are five or more package maintainers pinged in an issue, don't bother writing back. @bergmark @DanBurton @juhp Any thoughts on that? |
Whatever helps You best Michael! On Monday, September 21, 2015, Michael Snoyman notifications@github.com
Pozdrawiam |
👍 |
Due to the breaking change that got released mentioned by @phadej, I would recommend that nobody use aeson 0.10 for now. There is already a pull request to attempt to fix this situation: haskell/aeson#288 |
@gregwebs yeah I've been holding out to see how that clears up. |
For webdriver, my solution was to simply add a new operator to Test.WebDriver.JSON and use it in place of .:? (.:??) :: FromJSON a => Object -> Text -> Parser (Maybe a)
o .:?? k = fmap join (o .:? k) I believe this should have the same result regardless of which aeson version you use. |
I used Adam's solution in json-autotype too, and it passed all unit tests On Monday, 28 September 2015, Adam Curtis notifications@github.com wrote:
Pozdrawiam |
I was a bit impatient so I made Data.Aeson.Compat |
Fixed in http://hackage.haskell.org/package/bloodhound-0.9.0.0 but I had to bring the lower-bound up to 0.10. Current LTS Aeson is 0.8.0.2, let me know if this'll be a problem. |
Update: aeson-0.10.0.0 depended on by:
postgresql-binary-0.7.4.1 depended on by:
|
Fixed eventstore https://hackage.haskell.org/package/eventstore-0.9.1.2 |
@tmcgilchrist I am not sure what you're asking. You can check the Travis build for |
@tmcgilchrist Do you mean if there are other dependencies you might need to bump? If you can build against the latest nightly and |
Whenever your code handle |
@tmcgilchrist okay thanks - looks good now |
houath is bump to 0.5.0 in order to work with aeson-0.10 |
In my opinion, it was premature to add aeson 0.10 to stackage. The problem noted in haskell/aeson#296 essentially makes it impossible to compile pandoc-types on a machine with 2 GB RAM or less. Once pandoc enters lts-4.0, many people are going to find that As long as aeson 0.10 is in stackage, I'm faced with the choice between putting an upper bound on aeson in pandoc-types, thus excluding the pandoc ecosystem from stackage, or having many users complain that they are unable to install pandoc. (Yes, I know there are workarounds; you can specify a constraint on aeson; but most people aren't going to know that, and there's no way to figure out that that's what is needed.) See my comment on haskell reddit. |
@jgm the problem is with the generics-based default implementation, right? As an implementation workaround, how about using Data.Aeson.TH instead? |
@DanBurton I've studiously avoided using any TH in pandoc, due to problems I had in the past with TH + Windows (I can't recall the details now). Does Data.Aeson.TH generate the same JSON mapping as the generics implementation? |
@jgm it does, IIRC there are actual tests for that in |
Even if there is a workaround, I think my point stands. The aim of stackage is to provide a consistent set of packages that make building Haskell projects unproblematic. If one of the packages makes projects (not just mine, but anything that derives generic instances for complex product or sum types) unbuildable on machines without lots of RAM, that strikes me as a reason not to include it until the relevant bugs are fixed. |
@jgm but that sounds as a bug in GHC, not the package itself. |
The Being dependent upon |
Can anyone get in touch with @bos? I think the community can benefit from having additional official maintainers of aeson that are focused on shouldering the burden of stability, releases, and responsiveness. |
@phadej Well, it seems to be an interaction between changes specific to aeson 0.10 and ghc 7.10.3. Earlier version of aeson do not have the same problem, even with ghc 7.10.3. So the hope is that something can be fixed in aeson, even independent of fixes to ghc. Someone just commented on the aeson issue that removing the INLINE pragmas might do it. |
We stackage curators have been considering our options. We didn't properly take the regressions of aeson-0.10 into consideration when we selected it for LTS-4; we intend to take action over the next few days to remedy the situation. |
I'd like to help with aeson situation, if only there is something I can help with. |
heads up: aeson just merged a PR to revert some of the 0.10 nullability change: |
Also, we're exploring a workaround to |
@brendanhay (and @ all) as of tonight's nightly, aeson 0.9 is back, and you're no longer in the naughty section for failing to support aeson 0.10.0.0. lts-5 will be released (planned for 2016-01-24) with aeson 0.9. See #1155 for details. |
Thank you! |
I've opened a pull request to |
To whomever is still listening to this thread, aeson-0.11 is being prepared for release. If you can clone the repo and test it out with your package, it would be much appreciated. |
I will! |
At least |
also |
aeson-0.10.0.0 depended on by:
The text was updated successfully, but these errors were encountered: