Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures when using as lib #228

Closed
stuarthendren opened this issue Sep 19, 2021 · 1 comment · Fixed by #229
Closed

Test failures when using as lib #228

stuarthendren opened this issue Sep 19, 2021 · 1 comment · Fixed by #229
Labels
released

Comments

@stuarthendren
Copy link
Contributor

The match media query in the ThemeProvider causes test failures, for some reason the jest mock for window doesn't seam to work.
Nor if moved to global.

Can we make it not error if the value is not present on the window object.

Assignees: stuarthendren
Labels: bug
stuarthendren added a commit that referenced this issue Sep 19, 2021
@stuarthendren
fix: allows tests to run without jest fix for media query
2c394af 
Window listeners now added conditionally, improves tests. Also fixes incorrect switch in Monospace

fix #228
@stuarthendren stuarthendren mentioned this issue Sep 19, 2021
Merged
@commitd-bot
Copy link
Contributor

🎉 This issue has been resolved in version 6.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allows tests to run without jest fix for media query commitd/components
2 participants
@stuarthendren @commitd-bot