Major update adda new Form components and fixes SRR issues #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started with an update to dependencies and the required fixes. This required significant work in the dev support (tests/stories). Changes in components now require some global Providers so a new component provider has been added to wrap them all together. BREAKING CHANGE: It is now reccommended that you wrap the application with `ComponentsProvider` replacing the `ThemeProvider`. This includes all required components. fix #253
For both Menu and ContextMenu Extracts common styles to utilities fix #250
The Theme provider uses window and causes issues if SRR. This should now fail safe. And separate options are available to use the themes server side. fix #249
As to fix the usage with other link providers such as ReactRouter by using the simpler Radix asChild approach over the Stiches `as`. Also exposes the component parts so easier to make your own. BREAKING CHANGE: Users of Link `as` prop should change to `asChild` and nest the component with any of it's own props. fix #256
Adds helpers to simplify the creation of Forms. Form, FormButton, FormControl FormControlHelp These are form framework/lib independent. Required updates to the input types to support the API. fix #248
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
FormandFormControlcomponents.Updates
ThemeProviderfor SSRAdd new
ComponentsProviderto wrap all providers.