Skip to content

feat: adds menubutton component to be a trigger with chevron #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2022

Conversation

kristian-committed
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Bug fix
[ x ] Enhancement
[ ] Documentation
[ ] Deployment
[ ] Process (e.g. improve continuous integration)
[ ] Other, please explain:

Which issue (if any) does this pull request address?

Fixes #272

Screenshot 2022-05-13 at 14 51 34

Copy link
Contributor

@stuarthendren stuarthendren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't expecting you to do this so I'm happy to make the changes for you?

minor css fix and improvements to stories to reccoment MenuButton as the default
This adds in the `@motion` media query to many places it was missed. Fixes forward ref issue with
Avatar and fixes slide in for Toast.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@stuarthendren stuarthendren merged commit 05e9027 into main May 17, 2022
@stuarthendren stuarthendren deleted the ka-menu-triggers branch May 17, 2022 11:36
@commitd-bot
Copy link
Contributor

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chevron indicator to menu triggers
3 participants