Convert relative paths to absolute when checking links #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarthendren
requested changes
Jun 12, 2020
example/docs/tests/a/index.md
Outdated
| To link relatively to the folder `b` you should use, [b/](b/) or [b/index](b/index) the last has the advantage that is also works in the raw markdown. A full link is also valid [/tests/a/b/](/tests/a/b/) or [/tests/a/b/index](/tests/a/b/index) linking to headings is also supported [b/#link-test](b/#link-test) and [b/index#link-test](b/index#link-test). | ||
| To link relatively to the folder `b` you should use, [b/](b/) or [b/index](b/index) the last has the advantage that is also works in the raw markdown. A full link is also valid [/tests/a/b/](/tests/a/b/) or [/tests/a/b/index](/tests/a/b/index) linking to headings is also supported [b/#link-test](b/#link-test) and [b/index#link-test](b/index#link-test). | ||
|
|
||
| You can also link 'up' directories, for example: [../a](../a), [../a/mdTest](../../tests/mdTest), [../../tests/a/b#link-test](../../tests/a/b#link-test) |
There was a problem hiding this comment.
NIT I don't like these examples as they come back in to a or it's children they are not links you would actually write.
Also the second one is different in the display and the actual link.
There was a problem hiding this comment.
Updated link text
Not intending to change the links themselves. Agree they are contrived but they're there to demonstrate the concepts of "upward relative" linking and they do that adequately IMO.
added 3 commits
June 12, 2020 17:55
stuarthendren
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution takes a relative link to check (eg
../../test/a) and converts it to an absolute link (/docs/test/a).This also adds a second attempt at finding headers for links - ie if finding headers for
/afails, then try again for/a/Closes #28