Adds useModel and changes build #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuarthendren
force-pushed
the
sh/44
branch
4 times, most recently
from
a384b57 to
75520cf
Compare
tsdx was failing with a typescript error but tsc passes. This seemed to be a false positive that I could do nothing about. This is probably why useModal was left out of the build. Trying microbundle as very easy to set up. Worked well.
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
useModal was missing from the index - this was due to it causing the build to fail.
The failure seemed to be a false positive as built fine with tsc.
As tsdx is not maintained the build has changed to microbundle. This was easy to set up.
Left the other tsdx parts in for now to be removed later (#45)