Added dependsOn to module and project config, switched apply to apply… #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as a graph traversal.
davidcheung
reviewed
Jun 24, 2020
| @@ -63,9 +53,33 @@ func (c *ZeroProjectConfig) Print() { | |||
| pp.Println(c) | |||
| } | |||
|
|
|||
| func NewModule(parameters Parameters, directory string, repository string, source string) Module { | |||
| // GetDAG returns a graph of the module names used in this project config | |||
| func (c *ZeroProjectConfig) GetDAG() dag.AcyclicGraph { | |||
There was a problem hiding this comment.
using AcyclicGraph is slick 🕶️ 🕶️
There was a problem hiding this comment.
Yeah it was nice to be able to handle dependencies in what is probably going to end up being the necessary way, but also be able to do it quite easily!
davidcheung
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… as a graph traversal.