ZERO138 show summary at the end of Apply #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjhawkins
commented
Jun 26, 2020
| @@ -127,3 +128,39 @@ func validateEnvironments(applyEnvironments []string) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func summarizeAll(dir string, projectConfig projectconfig.ZeroProjectConfig) { | |||
| flog.Infof("Your projects and infrastructure have been successfully created. Here are some useful links and commands to get you started:") | |||
There was a problem hiding this comment.
I'm not sure about the Infof statements in this function.. just wanted to get placeholders in to show text at the beginning and end of the summary.
bmonkman
reviewed
Jun 29, 2020
| modulePath = filepath.Join(dir, modulePath) | ||
| } | ||
|
|
||
| envList = util.AppendProjectEnvToCmdEnv(mod.Parameters, envList) |
There was a problem hiding this comment.
Should also pass the environments in so the summary can show accurate info based on what was created.
bmonkman
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.