Add Wget dependency #248
Add Wget dependency #248
Conversation
cmd/check.go
Outdated
| command: "wget", | ||
| args: []string{"--version"}, | ||
| regexStr: `^GNU Wget (0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)`, | ||
| minVersion: "1.20.3", |
There was a problem hiding this comment.
looks like 1.20.3 is the latest one, people may not update their wget often
might be safer to go with some older versions as I doubt there's many breaking changes on wget
do you think it'll be good to allow some older versions too?
There was a problem hiding this comment.
Right! We're all probably using and testing on1.20.3 but I'm comfortable supporting a few minor version back 1.14.0 released in 2012. or further back?
There was a problem hiding this comment.
yeah 2012 definitely seems far back enough, I think as long as it covers most people's new computer cycle then its good 👍
| @@ -143,6 +143,14 @@ var checkCmd = &cobra.Command{ | |||
| minVersion: "2.17.1", | |||
| docsURL: "https://git-scm.com/book/en/v2/Getting-Started-Installing-Git", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Can you also bump the terraform to 0.13 please, the EKS stack's terraforms are now using some 0.13 features
|
Can you also please add it as a dependency for brew in |
* change wget min version * add wget to goreleaser config
Adds Wget as a zero dependency
closes #227