Skip to content

fix: missing projectName context in prompt:execute #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix: missing projectName context in prompt:execute #410

merged 1 commit into from
Aug 30, 2021

Conversation

davidcheung
Copy link
Contributor

reference in modules for projectName doesn't work anymore in places like https://github.com/commitdev/zero-backend-node/blob/8db8db64bce4d7772ea6de2d235aebe97edc5c2a/zero-module.yml#L127-L128

Looks like used to be appended from the projectCredentials

@davidcheung davidcheung requested a review from bmonkman August 30, 2021 19:51
bmonkman
bmonkman approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@bmonkman bmonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@davidcheung davidcheung merged commit 0672248 into main Aug 30, 2021
@davidcheung davidcheung deleted the fix-projectname-context branch August 30, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bmonkman bmonkman bmonkman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcheung @bmonkman