enhancement: git push command in doInitialCommit function
#425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
reviewed
Oct 19, 2021
internal/vcs/create-git-repos.go
Outdated
| output, err := cmd.CombinedOutput() | ||
|
|
||
| if err != nil { | ||
| initDefaultBranch = "master" |
There was a problem hiding this comment.
Let's return main instead, as this is the default in GitHub anyway.
There was a problem hiding this comment.
Also, mind sticking with the Go convention of having the happy path be left aligned without the explicit else? Like:
if err != nil {
return "main"
}
return string(output)
There was a problem hiding this comment.
Thanks for the feedback! I will fix it and push on gmlwo530:initialCommit.
gmlwo530
force-pushed
the
initialCommit
branch
from
b05a3bc to
9a1fc2f
Compare
bmonkman
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhancement: git push command use branch name from init.defaultBranch in git config.
(For #424)