Cleaned up dockerfile, moved create test #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
commented
Oct 22, 2019
|
|
||
| FROM alpine:edge | ||
| FROM alpine:3.10 |
There was a problem hiding this comment.
Edge is the dev version, we should pin to a stable version.
bmonkman
commented
Oct 22, 2019
| mv commit0 /usr/local/bin | ||
| RUN upx --lzma /usr/local/bin/* | ||
| mv commit0 /usr/local/bin && \ | ||
| upx --lzma /usr/local/bin/commit0 |
There was a problem hiding this comment.
Separating this into two steps means most of the time we only need to re-compress the commit0 binary, not the other stuff that never changes.
bmonkman
commented
Oct 22, 2019
| @@ -0,0 +1,7 @@ | |||
| Dockerfile | |||
There was a problem hiding this comment.
We should make sure to make this file as strict as possible, otherwise all this stuff gets included in COPY . . and busts the cache for all sorts of changes to various files.
Pritesh-Patel
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.