#64 : Remove -l flag, move all configuration to yaml, a lot of refact… #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direside
reviewed
Nov 1, 2019
| @@ -10,73 +10,20 @@ import ( | |||
| "github.com/commitdev/commit0/internal/templator" | |||
| ) | |||
|
|
|||
| func TestGenerateJenkins(t *testing.T) { | |||
There was a problem hiding this comment.
I guess these cases are covered by the integration tests now anyway, plus the logic inside of the CI generator is much simpler now.
Direside
approved these changes
Nov 1, 2019
internal/generate/proto/generate.go
Outdated
| } | ||
|
|
||
| func GenerateProtoServiceLibs(config *config.Commit0Config) { | ||
| idlRoot := fmt.Sprintf("%s-idl", config.Name) | ||
| func GenerateProtoServiceLibs(service config.Service) { |
There was a problem hiding this comment.
Before the idl repo produced would be a single repo that contained all the service idls & generated code split by folders, mainly for sharing protos (such as health) and for ease of use - is the intention to change this to multiple repos?
| mkdir -p gen/{{ $language }} | ||
| protoc ${PROTO_SOURCES} --{{ $language }}_out=plugins=grpc,paths=source_relative:proto ./proto/health/*.proto | ||
| {{- range .Services}} |
There was a problem hiding this comment.
Related to the comment above, if this is removed how are the the service proto generation commands produced?
| generate-http: | ||
| mkdir -p gen/go | ||
| protoc ${PROTO_SOURCES} --grpc-gateway_out=logtostderr=true,paths=source_relative:proto --swagger_out=logtostderr=true:proto ./proto/health/*.proto | ||
| {{- range .Services}} |
There was a problem hiding this comment.
Same question for above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oring
Mostly done, but I feel like the proto stuff might still need some love.