changelog generator got messed up with annotated tags

[trim21]

Description

Tags are mssing in generated tags

Steps to reproduce

git clone https://github.com/Trim21/transmission-rpc.git

cd transmission-rpc

pip install -U commitizen

cz changelog

git tag -l

Current behavior

annotated tags like v3.2.2 and v3.2.1 are missing from changelog

Desired behavior

generate a changelog with all kind of tags

Environment

• commitizen version: 2.17.4
• python version: 3.8.9
• operating system: Windows

[woile]

Hello @trim21 I just confirmed this bug, I think we have to run the get_tags function with creatordate instead of committerdate. I'll try to submit a patch soon. Thanks 👍🏻

git tag --format="%(refname:lstrip=2)---inner_delimiter---%(objectname)---inner_delimiter---%(creatordate:format:%Y-%m-%d)\n" --sort=-creatordate

[trim21]

Hello @trim21 I just confirmed this bug, I think we have to run the get_tags function with creatordate instead of committerdate. I'll try to submit a patch soon. Thanks 👍🏻

git tag --format="%(refname:lstrip=2)---inner_delimiter---%(objectname)---inner_delimiter---%(creatordate:format:%Y-%m-%d)\n" --sort=-creatordate

Thanks.

There's another bug about detecting the tagging time. It will get fixed with this, but this patch won't fix this issue, I have tried that.

The reason is that annotated tag's objectname is not same with it's commit, so changelog.get_commit_tag is not working correctly.

commitizen/commitizen/changelog.py

Lines 63 to 66 in aa0debe

	def get_commit_tag(commit: GitCommit, tags: List[GitTag]) -> Optional[GitTag]:
	return next((tag for tag in tags if tag.rev == commit.rev), None)

[woile]

I was playing with your project and by adding object I managed to get the related commit hash:

git tag --format="%(refname:lstrip=2)---inner_delimiter---%(objectname)---inner_delimiter---%(creatordate:format:%Y-%m-%d)----%(object)\n" --sort=-creatordate

I think when parsing tag, if object is not None, it should be used as rev

commitizen/commitizen/git.py

Lines 105 to 111 in aa0debe

	c = cmd.run(f"git tag --format={formatter} --sort=-committerdate")
	if c.err or not c.out:
	return []
	git_tags = [GitTag(*line.split(inner_delimiter)) for line in c.out.split("\n")[:-1]]
	return git_tags