Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow releasing after a release candidate without commits #751

Closed
Alexander-Serov opened this issue May 23, 2023 · 2 comments
Closed

Allow releasing after a release candidate without commits #751

Alexander-Serov opened this issue May 23, 2023 · 2 comments
Labels
type: feature A new enhacement proposal

Comments

@Alexander-Serov
Copy link

Alexander-Serov commented May 23, 2023

Description

In our company, we make a release candidate and if it works, perform the full release. Currently, this logic is not compatible with cz bump because it always requires to have commits. Here is an example of the log:

The release candidate bump:

$ cz bump -pr rc 
bump: version 0.6.0 → 0.6.1rc0
tag to create: v0.6.1rc0
increment detected: PATCH
[detached HEAD de92ff6] bump: version 0.6.0 → 0.6.1rc0
 1 file changed, 11 insertions(+)

Attempting to do a real release on the commit tagged as 0.6.1rc0:

$ cz bump
bump: version 0.6.1rc0 → 0.6.1
tag to create: v0.6.1
No commits found

and exits with the exit code 3.

Possible Solution

Sometimes a release candidate is good. Let us just allow updating the changelog and tag that commit.

Additional context

We are using changelog_merge_prerelease = True so I would expect a changelog entry with the same info as in 0.6.1rc0 to be created, committed and tagged.

We have also tried to ignore the error and force proceed with

cz bump -nr 3

as indicated in the Documentation, but that gave the same result.

Additional context

No response

@Alexander-Serov Alexander-Serov added the type: feature A new enhacement proposal label May 23, 2023
@Alexander-Serov Alexander-Serov changed the title Allow releasing after a release candidates without commits Allow releasing after a release candidate without commits May 23, 2023
@aferreirap
Copy link

Our company would also be impacted by this feature!

@Lee-W
Copy link
Member

Lee-W commented May 20, 2024

I just tested it with the latest version (3.26.0), and it seems to work fine. I'm closing this one. Please feel free to reopen if the feature does not work. Thanks! 🙂

@Lee-W Lee-W closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new enhacement proposal
Projects
None yet
Development

No branches or pull requests

3 participants