Skip to content

Refactor config #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 27, 2019
Merged

Refactor config #100

merged 12 commits into from
Dec 27, 2019

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Dec 18, 2019 •
edited
Loading

  • Refactor config
    • Create a BaseConfig class for the default configuration
    • Use TomlConfig and IniConfig to separate the logic of parsing different type of config file
  • Use new config structure to fix the previously fixed Issue name cannot be overwritten in config #97
  • Rename the config inside a config object as settings
  • Use config class as an argument for cz and commands instead of dict config

Lee-W added 9 commits December 18, 2019 10:17
@Lee-W
refactor(config): Make config a class and each type of config (e.g., …
c178633 
…toml, ini) a child class

* Use new config structure to fix the previously fixed Issue commitizen-tools#97
* Rename the config inside a config as settings
* Use config class as argument for cz and commands instead of dict config
* Remove settings from default
@Lee-W
fix(config/ini_config): replase outdated _parse_ini_settings with _pa…
9efa8e2 
…rse_settings
@Lee-W
fix(config): fix load global_conf even if it doesn't exist
075508a
@Lee-W
refactor(config): move default settings back to defaults
e551cb1
@Lee-W
test(all): fix test break due to refactoring
f726ef4 
note that empty config file is not yet handled. should be fix in next commit
@Lee-W
fix(config): handle empty config file
1d4a4d6
@Lee-W
refactor(cz/customize): remove unnecessary statement "raise NotImplem…
de810af 
…entedError("Not Implemented yet")"
@Lee-W
refactor(all): replace all the _settings invoke with settings.update
5ef5f63
@Lee-W
refactor(config): use add_path instead of directly assigning _path
467b492
@woile
Copy link
Member

woile commented Dec 18, 2019

Wow, great work Lee, I will review it this week

This was referenced Dec 26, 2019
Merged
Merged
Merged
Closed
woile
woile reviewed Dec 27, 2019
View reviewed changes
woile
woile reviewed Dec 27, 2019
View reviewed changes
woile
woile reviewed Dec 27, 2019
View reviewed changes
woile
woile reviewed Dec 27, 2019
View reviewed changes
woile
woile reviewed Dec 27, 2019
View reviewed changes
@Lee-W
Copy link
Member Author

Lee-W commented Dec 27, 2019

Maybe we can add mypy check in the future? But I think it might be better to do it after these PRs.

@woile woile merged commit 48ce191 into commitizen-tools:master Dec 27, 2019
@Lee-W Lee-W deleted the refactor-config branch December 30, 2019 01:06
Lee-W added a commit to Lee-W/commitizen that referenced this pull request Dec 31, 2019
@Lee-W
fix(scripts/test): ensure the script fails once the first failure hap…
9b4915b 
…pens

commitizen-tools#100
@Lee-W Lee-W mentioned this pull request Dec 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lee-W @woile