Skip to content

Conversation

Cliying94
Copy link

related: #572

Description

add-a-test-for-handling-blank-with-path-in-git-commit

  • mock action:
    Whether the path includes blank or not, the git commit action can parse anyway and correctly execute commit under commitizen/commitizen/git.py and go through the util function create_file_and_commit

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

if the project path is including blank, the program should work.

Steps to Test This Pull Request

run ./scripts/test or run the single text test_git_commit_command_with_varied_paths_handles_blank under tests/test_git.py

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (120d514) to head (ef51f24).
⚠️ Report is 757 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   97.33%   97.48%   +0.15%     
==========================================
  Files          42       55      +13     
  Lines        2104     2429     +325     
==========================================
+ Hits         2048     2368     +320     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.48% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W
Copy link
Member

Lee-W commented Aug 24, 2025

As this has no update since last year and there might be lots of conflicts, I'm going to close this one. Feel free to reopen it, if we still want this improvement in 🙂

@Lee-W Lee-W closed this Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants