Skip to content

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Sep 15, 2025

…stract method

Description

  • Removed the NotImplementedErrors in the abstract class BaseCommitizen
  • Removed the test file which tests the behavior of BaseCommitizen. I believe we don't need to test the abstract class.

I have read the git blame to those changes. I didn't find a reason to not make them abstract.

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4-9-2@cc981fc). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             v4-9-2    #1608   +/-   ##
=========================================
  Coverage          ?   98.25%           
=========================================
  Files             ?       58           
  Lines             ?     2698           
  Branches          ?        0           
=========================================
  Hits              ?     2651           
  Misses            ?       47           
  Partials          ?        0           
Flag Coverage Δ
unittests 98.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W changed the base branch from master to v4-9-2 September 15, 2025 15:29
@Lee-W Lee-W merged commit 1bb40c7 into commitizen-tools:v4-9-2 Sep 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants