-
-
Notifications
You must be signed in to change notification settings - Fork 298
feat(bump): add optional --no-verify argument for bump command #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bump): add optional --no-verify argument for bump command #183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 91.76% 92.02% +0.26%
==========================================
Files 35 35
Lines 947 953 +6
==========================================
+ Hits 869 877 +8
+ Misses 78 76 -2
Continue to review full report at Codecov.
|
@woile what do you think about that? |
I also encounter the same problem. I'm thinking of adding a |
@Lee-W i changed this pr to make --no-verify as optional argument :) |
846a31f
to
4b79ab1
Compare
4b79ab1
to
6816c6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kudlatyamroth ! This problem bothers me for some time. This PR looks great! But you might need to add some test cases to cover this new argument so that we'll be able to merge it.
commitizen/cli.py
Outdated
"name": ["--no-verify"], | ||
"action": "store_true", | ||
"default": False, | ||
"help": "disable git hooks during bumping", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just take a look of the documentation of git. The help message is
--no-verify
This option bypasses the pre-commit and commit-msg hooks.
I think it might be better if we can align with them
6816c6e
to
5fc1033
Compare
5fc1033
to
b8f2894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @kudlatyamroth Thanks for your help! Let's merge it!
@Lee-W thanks for merge :) should check for |
@kudlatyamroth It's probably due to #157 I'll take a look tomorrow |
fix: #164
When we have in repo some pre-commit hooks, like black, mypy or anything like that
cz bump fails, even if pre-commit hooks passed.
it is strange as pre-commit write messages to sys.stdout.buffer not stderr...
example pre-commit config:
This PR add optional --no-verify argument to bump command